Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Query String for rollups #2428

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Add Query String for rollups #2428

merged 3 commits into from
Jan 19, 2023

Conversation

Naarcha-AWS
Copy link
Collaborator

Signed-off-by: Naarcha-AWS naarcha@amazon.com

Description

Relates to #2427.

Fixes #2341.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
@Naarcha-AWS Naarcha-AWS added 4 - Doc Review PR: Doc review in progress v2.5.0 'Issues and PRs related to version v2.5.0' release-notes PR: Include this PR in the automated release notes labels Jan 19, 2023
@Naarcha-AWS Naarcha-AWS requested a review from a team as a code owner January 19, 2023 16:31
@Naarcha-AWS Naarcha-AWS self-assigned this Jan 19, 2023
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; one typo fix.

_im-plugin/index-rollups/index.md Outdated Show resolved Hide resolved
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
@carolxob carolxob self-requested a review January 19, 2023 16:35
Copy link
Contributor

@ariamarble ariamarble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@carolxob carolxob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor suggestion.

Co-authored-by: Caroline <113052567+carolxob@users.noreply.github.com>
@Naarcha-AWS Naarcha-AWS added 6 - Done but waiting to merge PR: The work is done and ready to merge and removed 4 - Doc Review PR: Doc review in progress labels Jan 19, 2023
@Naarcha-AWS Naarcha-AWS merged commit c7837cb into main Jan 19, 2023
@Naarcha-AWS Naarcha-AWS deleted the query-rollups branch January 19, 2023 16:39
vagimeli pushed a commit that referenced this pull request Jan 19, 2023
* Add Query String for rollups

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>

* Update _im-plugin/index-rollups/index.md

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>

* Update _im-plugin/index-rollups/index.md

Co-authored-by: Caroline <113052567+carolxob@users.noreply.github.com>

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Co-authored-by: Caroline <113052567+carolxob@users.noreply.github.com>
vagimeli pushed a commit that referenced this pull request Jan 25, 2023
* Add Query String for rollups

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>

* Update _im-plugin/index-rollups/index.md

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>

* Update _im-plugin/index-rollups/index.md

Co-authored-by: Caroline <113052567+carolxob@users.noreply.github.com>

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Co-authored-by: Caroline <113052567+carolxob@users.noreply.github.com>
vagimeli added a commit that referenced this pull request Jan 26, 2023
vagimeli added a commit that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6 - Done but waiting to merge PR: The work is done and ready to merge release-notes PR: Include this PR in the automated release notes v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Query String Query support in Rollups
4 participants