add two new settings for Anomaly Detection 2.5 #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
kaituo
approved these changes
Jan 20, 2023
kolchfa-aws
reviewed
Jan 20, 2023
_monitoring-plugins/ad/settings.md
Outdated
| @@ -45,3 +45,5 @@ plugins.anomaly_detection.delete_anomaly_result_when_delete_detector | False | W | |||
| plugins.anomaly_detection.dedicated_cache_size | 10 | If the real-time analysis of a high cardinality detector starts successfully, the anomaly detection plugin guarantees keeping 10 (dynamically adjustable via this setting) entities' models in memory per node. If the number of entities exceeds this limit, the plugin puts the extra entities' models in a memory space shared by all detectors. The actual number of entities varies based on the memory that you've available and the frequencies of the entities. If you'd like the plugin to guarantee keeping more entities' models in memory and if you're cluster has sufficient memory, you can increase this setting value. | |||
| plugins.anomaly_detection.max_concurrent_preview | 2 | The maximum number of concurrent previews. You can use this setting to limit resource usage. | |||
| plugins.anomaly_detection.model_max_size_percent | 0.1 | The upper bound of the memory percentage for a model. | |||
| plugins.anomaly_detection.door_keeper_in_cache.enabled | False | We have a bloom filter placed in front of an inactive entity cache to filter out unpopular items that are not likely to appear more than once. This setting allows you to either enable the bloom filter or not. | |||
There was a problem hiding this comment.
Can we say "The anomaly detection plugin has a bloom filter"? To avoid the use of "we".
Suggested change
| plugins.anomaly_detection.door_keeper_in_cache.enabled | False | We have a bloom filter placed in front of an inactive entity cache to filter out unpopular items that are not likely to appear more than once. This setting allows you to either enable the bloom filter or not. | |
| plugins.anomaly_detection.door_keeper_in_cache.enabled | False | The anomaly detection plugin has a bloom filter placed in front of an inactive entity cache to filter out unpopular items that are not likely to appear more than once. This setting allows you to either enable or disable the bloom filter. |
kolchfa-aws
reviewed
Jan 20, 2023
_monitoring-plugins/ad/settings.md
Outdated
| @@ -45,3 +45,5 @@ plugins.anomaly_detection.delete_anomaly_result_when_delete_detector | False | W | |||
| plugins.anomaly_detection.dedicated_cache_size | 10 | If the real-time analysis of a high cardinality detector starts successfully, the anomaly detection plugin guarantees keeping 10 (dynamically adjustable via this setting) entities' models in memory per node. If the number of entities exceeds this limit, the plugin puts the extra entities' models in a memory space shared by all detectors. The actual number of entities varies based on the memory that you've available and the frequencies of the entities. If you'd like the plugin to guarantee keeping more entities' models in memory and if you're cluster has sufficient memory, you can increase this setting value. | |||
| plugins.anomaly_detection.max_concurrent_preview | 2 | The maximum number of concurrent previews. You can use this setting to limit resource usage. | |||
| plugins.anomaly_detection.model_max_size_percent | 0.1 | The upper bound of the memory percentage for a model. | |||
| plugins.anomaly_detection.door_keeper_in_cache.enabled | False | We have a bloom filter placed in front of an inactive entity cache to filter out unpopular items that are not likely to appear more than once. This setting allows you to either enable the bloom filter or not. | |||
| plugins.anomaly_detection.hcad_cold_start_interpolation.enabled | False | Whether interpolation in HCAD cold start is enabled or not. | |||
There was a problem hiding this comment.
Suggested change
| plugins.anomaly_detection.hcad_cold_start_interpolation.enabled | False | Whether interpolation in HCAD cold start is enabled or not. | |
| plugins.anomaly_detection.hcad_cold_start_interpolation.enabled | False | Whether interpolation in HCAD cold start is enabled. |
Naarcha-AWS
requested changes
Jan 20, 2023
Naarcha-AWS
added
the
release-notes
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Naarcha-AWS
approved these changes
Jan 23, 2023
vagimeli
pushed a commit
that referenced
this pull request
Jan 25, 2023
* add two new settings for Anomaly Detection Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * fixed setting mistake Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * Update _monitoring-plugins/ad/settings.md * Update _monitoring-plugins/ad/settings.md * Update _monitoring-plugins/ad/settings.md Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Amit Galitzky <amgalitz@amazon.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
vagimeli
pushed a commit
that referenced
this pull request
Jan 27, 2023
* add two new settings for Anomaly Detection Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * fixed setting mistake Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * Update _monitoring-plugins/ad/settings.md * Update _monitoring-plugins/ad/settings.md * Update _monitoring-plugins/ad/settings.md Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Amit Galitzky <amgalitz@amazon.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amit Galitzky amgalitz@amazon.com
Description
Add two new settings for AD plugin:
plugins.anomaly_detection.hcad_cold_start_interpolation.enabledandplugins.anomaly_detection.door_keeper_in_cache.enabledChecklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.