Add response close go client #2828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, @sheltie-fusafusa, for contributing! @VachaShah could you please review for technical accuracy? Thank you! |
The "Go package documentation" calls the Close method. https://pkg.go.dev/github.com/opensearch-project/opensearch-go#NewClient Signed-off-by: sheltie <sheltie.fusafusa@gmail.com>
Signed-off-by: sheltie <sheltie.fusafusa@gmail.com>
This reverts commit 6852b1c. Signed-off-by: sheltie <sheltie.fusafusa@gmail.com>
sheltie-fusafusa
force-pushed
the
add_response_close_go_client
branch
from
115c245
to
11074f6
Compare
VachaShah
approved these changes
Feb 17, 2023
carolxob
approved these changes
Feb 20, 2023
kolchfa-aws
added
backport 1.3
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 20, 2023
* I think response need to close. The "Go package documentation" calls the Close method. https://pkg.go.dev/github.com/opensearch-project/opensearch-go#NewClient Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * delete defer Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * Revert "delete defer" This reverts commit 6852b1c. Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> --------- Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> (cherry picked from commit 94e11ab)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 20, 2023
* I think response need to close. The "Go package documentation" calls the Close method. https://pkg.go.dev/github.com/opensearch-project/opensearch-go#NewClient Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * delete defer Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * Revert "delete defer" This reverts commit 6852b1c. Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> --------- Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> (cherry picked from commit 94e11ab)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 20, 2023
* I think response need to close. The "Go package documentation" calls the Close method. https://pkg.go.dev/github.com/opensearch-project/opensearch-go#NewClient Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * delete defer Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * Revert "delete defer" This reverts commit 6852b1c. Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> --------- Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> (cherry picked from commit 94e11ab)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 20, 2023
* I think response need to close. The "Go package documentation" calls the Close method. https://pkg.go.dev/github.com/opensearch-project/opensearch-go#NewClient Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * delete defer Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * Revert "delete defer" This reverts commit 6852b1c. Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> --------- Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> (cherry picked from commit 94e11ab)
This was referenced Feb 20, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 20, 2023
* I think response need to close. The "Go package documentation" calls the Close method. https://pkg.go.dev/github.com/opensearch-project/opensearch-go#NewClient Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * delete defer Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * Revert "delete defer" This reverts commit 6852b1c. Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> --------- Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> (cherry picked from commit 94e11ab)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 20, 2023
* I think response need to close. The "Go package documentation" calls the Close method. https://pkg.go.dev/github.com/opensearch-project/opensearch-go#NewClient Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * delete defer Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * Revert "delete defer" This reverts commit 6852b1c. Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> --------- Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> (cherry picked from commit 94e11ab)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 20, 2023
* I think response need to close. The "Go package documentation" calls the Close method. https://pkg.go.dev/github.com/opensearch-project/opensearch-go#NewClient Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * delete defer Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * Revert "delete defer" This reverts commit 6852b1c. Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> --------- Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> (cherry picked from commit 94e11ab)
kolchfa-aws
pushed a commit
that referenced
this pull request
Feb 20, 2023
* I think response need to close. The "Go package documentation" calls the Close method. https://pkg.go.dev/github.com/opensearch-project/opensearch-go#NewClient Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * delete defer Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * Revert "delete defer" This reverts commit 6852b1c. Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> --------- Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> (cherry picked from commit 94e11ab) Co-authored-by: sheltie <sheltie.fusafusa@gmail.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Feb 20, 2023
* I think response need to close. The "Go package documentation" calls the Close method. https://pkg.go.dev/github.com/opensearch-project/opensearch-go#NewClient Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * delete defer Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * Revert "delete defer" This reverts commit 6852b1c. Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> --------- Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> (cherry picked from commit 94e11ab) Co-authored-by: sheltie <sheltie.fusafusa@gmail.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Feb 20, 2023
* I think response need to close. The "Go package documentation" calls the Close method. https://pkg.go.dev/github.com/opensearch-project/opensearch-go#NewClient Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * delete defer Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * Revert "delete defer" This reverts commit 6852b1c. Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> --------- Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> (cherry picked from commit 94e11ab) Co-authored-by: sheltie <sheltie.fusafusa@gmail.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Feb 20, 2023
* I think response need to close. The "Go package documentation" calls the Close method. https://pkg.go.dev/github.com/opensearch-project/opensearch-go#NewClient Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * delete defer Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * Revert "delete defer" This reverts commit 6852b1c. Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> --------- Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> (cherry picked from commit 94e11ab) Co-authored-by: sheltie <sheltie.fusafusa@gmail.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Feb 20, 2023
* I think response need to close. The "Go package documentation" calls the Close method. https://pkg.go.dev/github.com/opensearch-project/opensearch-go#NewClient Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * delete defer Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * Revert "delete defer" This reverts commit 6852b1c. Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> --------- Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> (cherry picked from commit 94e11ab) Co-authored-by: sheltie <sheltie.fusafusa@gmail.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Feb 20, 2023
* I think response need to close. The "Go package documentation" calls the Close method. https://pkg.go.dev/github.com/opensearch-project/opensearch-go#NewClient Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * delete defer Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * Revert "delete defer" This reverts commit 6852b1c. Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> --------- Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> (cherry picked from commit 94e11ab) Co-authored-by: sheltie <sheltie.fusafusa@gmail.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Feb 20, 2023
* I think response need to close. The "Go package documentation" calls the Close method. https://pkg.go.dev/github.com/opensearch-project/opensearch-go#NewClient Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * delete defer Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> * Revert "delete defer" This reverts commit 6852b1c. Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> --------- Signed-off-by: sheltie <sheltie.fusafusa@gmail.com> (cherry picked from commit 94e11ab) Co-authored-by: sheltie <sheltie.fusafusa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Takumi Hamada sheltie.fusafusa@gmail.com
Description
I think response need to close.
because "Go package documentation" calls the Close method.
https://pkg.go.dev/github.com/opensearch-project/opensearch-go#NewClient
Issues Resolved
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.