Introduce new 'unsigned_long' numeric field type support #3585

reta · 2023-03-27T16:55:41Z

Description

Introduce new 'unsigned_long' numeric field type support

Issues Resolved

Related to opensearch-project/OpenSearch#2083 and opensearch-project/OpenSearch#6237

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ariamarble · 2023-03-30T20:03:43Z

@reta I see that this is still in a draft state. Is this still being worked on from your end, or is this ready for review?

reta · 2023-03-30T20:11:25Z

@reta I see that this is still in a draft state. Is this still being worked on from your end, or is this ready for review?

@ariamarble thanks for looking, wrapping up the test cases and related fixes (opensearch-project/OpenSearch#6901, opensearch-project/OpenSearch#6237), should be ready today / tomorrow

Naarcha-AWS · 2023-04-12T15:46:05Z

@reta: Any updates on this? Anything we can do to help?

reta · 2023-04-12T16:01:45Z

@reta: Any updates on this? Anything we can do to help?

Thanks @Naarcha-AWS the pull request in core is under review opensearch-project/OpenSearch#6237 but the feature won't make it till 2.8.0

reta · 2023-05-05T12:37:49Z

@Naarcha-AWS the feature has been merged to main and 2.x (upcoming 2.8.0), thank you for patience !

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

kolchfa-aws · 2023-05-23T19:57:47Z

Thank you, @reta! Would you prefer that I comment on the PR or edit directly so you can just review afterwards?

reta · 2023-05-23T20:15:15Z

Thank you, @reta! Would you prefer that I comment on the PR or edit directly so you can just review afterwards?

@kolchfa-aws totally up to you, whatever is more convenient for you, thanks!

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

kolchfa-aws · 2023-05-24T17:21:43Z

@reta Done. Could you please look it over to confirm technical accuracy? Thanks!

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

vagimeli

Minor edit. Looks good.

_field-types/supported-field-types/unsigned-long.md

Co-authored-by: Melissa Vagi <vagimeli@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>

reta · 2023-05-24T21:27:21Z

@reta Done. Could you please look it over to confirm technical accuracy? Thanks!

Thanks @kolchfa-aws , LGTM!

natebower

Just a few comments. Thanks!

_field-types/supported-field-types/unsigned-long.md

natebower · 2023-05-25T12:00:36Z

_field-types/supported-field-types/unsigned-long.md

+```
+{% include copy-curl.html %}
+
+If a field of type `unsigned_long` has the `store` parameter set to `true` (that is, the field is a stored field), it will be stored and returned as a string. `unsigned_long` values do not support the decimal part, so if supplied, the decimal part is truncated.


In both instances of "the decimal part", do we mean something like "the decimal portion of the [noun]"?

We mean the decimal part of the number (where "of the number" is implicitly understood).

_field-types/supported-field-types/unsigned-long.md

Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

…to issue-2083

* Introduce new 'unsigned_long' numeric field type support Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Readability improvements and style guide changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Rename file and fix links Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Update _field-types/supported-field-types/unsigned-long.md Co-authored-by: Melissa Vagi <vagimeli@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> * Add trailing slash to link Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Fanit Kolchina <kolchfa@amazon.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Melissa Vagi <vagimeli@amazon.com> Co-authored-by: Nathan Bower <nbower@amazon.com>

…project#3585) * Introduce new 'unsigned_long' numeric field type support Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Readability improvements and style guide changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Rename file and fix links Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Update _field-types/supported-field-types/unsigned-long.md Co-authored-by: Melissa Vagi <vagimeli@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> * Add trailing slash to link Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Fanit Kolchina <kolchfa@amazon.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Melissa Vagi <vagimeli@amazon.com> Co-authored-by: Nathan Bower <nbower@amazon.com>

reta mentioned this pull request Mar 27, 2023

Introduce new 'unsigned_long' numeric field type support opensearch-project/OpenSearch#6237

Merged

14 tasks

reta force-pushed the issue-2083 branch from 4e0dd8f to 2768b9b Compare March 29, 2023 18:06

reta marked this pull request as ready for review April 12, 2023 16:01

Naarcha-AWS self-requested a review May 10, 2023 18:25

Naarcha-AWS added v2.8.0 1 - Backlog Issue: The issue is unassigned or assigned but not started labels May 10, 2023

Introduce new 'unsigned_long' numeric field type support

861a124

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

reta force-pushed the issue-2083 branch from 2768b9b to 861a124 Compare May 23, 2023 19:28

reta requested review from cwillum, hdhalter, kolchfa-aws, vagimeli, ananzh, seanneumann, AMoo-Miki and natebower as code owners May 23, 2023 19:28

kolchfa-aws self-assigned this May 23, 2023

Readability improvements and style guide changes

2ad40af

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Rename file and fix links

63f524d

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

kolchfa-aws added 4 - Doc Review PR: Doc review in progress and removed 1 - Backlog Issue: The issue is unassigned or assigned but not started labels May 24, 2023

vagimeli approved these changes May 24, 2023

View reviewed changes

_field-types/supported-field-types/unsigned-long.md Outdated Show resolved Hide resolved

Update _field-types/supported-field-types/unsigned-long.md

2ef6bdf

Co-authored-by: Melissa Vagi <vagimeli@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>

kolchfa-aws added 5 - Final Editorial Review PR: Editorial Review in progress and removed 4 - Doc Review PR: Doc review in progress labels May 24, 2023

natebower reviewed May 25, 2023

View reviewed changes

natebower removed the 5 - Final Editorial Review PR: Editorial Review in progress label May 25, 2023

kolchfa-aws and others added 3 commits May 25, 2023 11:07

Apply suggestions from code review

a720d9f

Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>

Add trailing slash to link

c62fdab

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Merge branch 'issue-2083' of github.com:reta/documentation-website in…

0fa0a24

…to issue-2083

kolchfa-aws added the release-notes PR: Include this PR in the automated release notes label May 25, 2023

kolchfa-aws merged commit 2745dd5 into opensearch-project:main May 25, 2023
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce new 'unsigned_long' numeric field type support #3585

Introduce new 'unsigned_long' numeric field type support #3585

reta commented Mar 27, 2023

ariamarble commented Mar 30, 2023

reta commented Mar 30, 2023 •

edited

Naarcha-AWS commented Apr 12, 2023

reta commented Apr 12, 2023

reta commented May 5, 2023

kolchfa-aws commented May 23, 2023

reta commented May 23, 2023

kolchfa-aws commented May 24, 2023

vagimeli left a comment

reta commented May 24, 2023

natebower left a comment

natebower May 25, 2023

kolchfa-aws May 25, 2023

Introduce new 'unsigned_long' numeric field type support #3585

Introduce new 'unsigned_long' numeric field type support #3585

Conversation

reta commented Mar 27, 2023

Description

Issues Resolved

Checklist

ariamarble commented Mar 30, 2023

reta commented Mar 30, 2023 • edited

Naarcha-AWS commented Apr 12, 2023

reta commented Apr 12, 2023

reta commented May 5, 2023

kolchfa-aws commented May 23, 2023

reta commented May 23, 2023

kolchfa-aws commented May 24, 2023

vagimeli left a comment

Choose a reason for hiding this comment

reta commented May 24, 2023

natebower left a comment

Choose a reason for hiding this comment

natebower May 25, 2023

Choose a reason for hiding this comment

kolchfa-aws May 25, 2023

Choose a reason for hiding this comment

reta commented Mar 30, 2023 •

edited