Add thread level details to _tasks API #4542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jed326
requested review from
cwillum,
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
ananzh,
seanneumann,
AMoo-Miki and
natebower
as code owners
|
@sohami Could you double check this PR for me? Thanks! |
sohami
reviewed
Jul 11, 2023
Signed-off-by: Jay Deng <jayd0104@gmail.com>
|
@hdhalter @kolchfa-aws could you take a look at this PR now and let me know if the formatting / wording looks good? Thanks! |
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
|
@jed326 Thanks so much for contributing this documentation! I've made some tweaks so it adheres to our style guide. If you have no other changes, we can push this documentation forward. |
sohami
approved these changes
Jul 11, 2023
|
@kolchfa-aws Looks good to me, thanks for the edits! |
kolchfa-aws
approved these changes
Jul 11, 2023
kolchfa-aws
added
v2.9.0
release-notes
natebower
reviewed
Jul 12, 2023
_api-reference/tasks.md
Outdated
| `total` | The sum of resource usages across all scheduled thread executions. | | ||
| `min` | The minimum resource usage across all scheduled thread executions. | | ||
| `max` | The maximum resource usage across all scheduled thread executions. | | ||
| `thread_info` | Thread count-related stats.| |
There was a problem hiding this comment.
If this means "count-related stats for the thread", then the hyphenation is correct, but confirm that it shouldn't be "thread-count-related stats".
There was a problem hiding this comment.
It is "thread-count-related". I'll change.
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
kolchfa-aws
added
6 - Done but waiting to merge
kolchfa-aws
changed the title
_tasks API
kolchfa-aws
changed the title
_tasks API
harshavamsi
pushed a commit
to harshavamsi/documentation-website
that referenced
this pull request
Oct 31, 2023
* Add thread level details to _tasks API Signed-off-by: Jay Deng <jayd0104@gmail.com> * Rewording according to style guide and formatting changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Update _api-reference/tasks.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> * Update tasks.md Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> --------- Signed-off-by: Jay Deng <jayd0104@gmail.com> Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Fanit Kolchina <kolchfa@amazon.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com>
vagimeli
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Add thread level details to _tasks API Signed-off-by: Jay Deng <jayd0104@gmail.com> * Rewording according to style guide and formatting changes Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Update _api-reference/tasks.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> * Update tasks.md Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> --------- Signed-off-by: Jay Deng <jayd0104@gmail.com> Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Fanit Kolchina <kolchfa@amazon.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the sample response for
_tasksAPI with detailed flag to include the new thread level response.Issues Resolved
Resolves #4206
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.