Add updates to creating a detector UX #5176

hdhalter · 2023-10-09T19:30:46Z

Description

Security analytics - create detector - UX changes

Issues Resolved

fixes #5157

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Heather Halter <hdhalter@amazon.com>

hdhalter · 2023-10-09T21:27:49Z

@amsiglan - please review the changes from a technical standpoint. Thanks!

_security-analytics/sec-analytics-config/detectors-config.md

_security-analytics/index.md

_security-analytics/usage/findings.md

Naarcha-AWS

A couple of nits that you should confirm with Nate Bower. Otherwise, LGTM.

Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

natebower

@hdhalter Please see my comments and changes and let me know if you have any questions. Thanks!

_security-analytics/index.md

_security-analytics/sec-analytics-config/detectors-config.md

_security-analytics/usage/findings.md

Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

hdhalter · 2023-10-12T21:32:43Z

The formatting of the subsections is off. I will fix.

Signed-off-by: Heather Halter <hdhalter@amazon.com>

hdhalter · 2023-10-12T22:01:50Z

@natebower - all feedback has been resolved if you want to take another look!

natebower

@hdhalter LGTM with noted minor changes. Thanks!

_security-analytics/sec-analytics-config/detectors-config.md

Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

hdhalter · 2023-10-13T14:48:56Z

Thanks, Nathan!

* detector draft Signed-off-by: Heather Halter <hdhalter@amazon.com> * updated screen shots and fixed links Signed-off-by: Heather Halter <hdhalter@amazon.com> * fix links Signed-off-by: Heather Halter <hdhalter@amazon.com> * remove strange character Signed-off-by: Heather Halter <hdhalter@amazon.com> * Update _security-analytics/index.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _security-analytics/usage/findings.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _security-analytics/sec-analytics-config/detectors-config.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _security-analytics/sec-analytics-config/detectors-config.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _security-analytics/usage/findings.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * fixed substep formatting problem Signed-off-by: Heather Halter <hdhalter@amazon.com> * Update _security-analytics/sec-analytics-config/detectors-config.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> --------- Signed-off-by: Heather Halter <hdhalter@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com>

This reverts commit f3007fc.

* detector draft Signed-off-by: Heather Halter <hdhalter@amazon.com> * updated screen shots and fixed links Signed-off-by: Heather Halter <hdhalter@amazon.com> * fix links Signed-off-by: Heather Halter <hdhalter@amazon.com> * remove strange character Signed-off-by: Heather Halter <hdhalter@amazon.com> * Update _security-analytics/index.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _security-analytics/usage/findings.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _security-analytics/sec-analytics-config/detectors-config.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _security-analytics/sec-analytics-config/detectors-config.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _security-analytics/usage/findings.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * fixed substep formatting problem Signed-off-by: Heather Halter <hdhalter@amazon.com> * Update _security-analytics/sec-analytics-config/detectors-config.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> --------- Signed-off-by: Heather Halter <hdhalter@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

This reverts commit f3007fc. Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* detector draft Signed-off-by: Heather Halter <hdhalter@amazon.com> * updated screen shots and fixed links Signed-off-by: Heather Halter <hdhalter@amazon.com> * fix links Signed-off-by: Heather Halter <hdhalter@amazon.com> * remove strange character Signed-off-by: Heather Halter <hdhalter@amazon.com> * Update _security-analytics/index.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _security-analytics/usage/findings.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _security-analytics/sec-analytics-config/detectors-config.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _security-analytics/sec-analytics-config/detectors-config.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _security-analytics/usage/findings.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * fixed substep formatting problem Signed-off-by: Heather Halter <hdhalter@amazon.com> * Update _security-analytics/sec-analytics-config/detectors-config.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> --------- Signed-off-by: Heather Halter <hdhalter@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

This reverts commit f3007fc. Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

This reverts commit c384b10.

* detector draft Signed-off-by: Heather Halter <hdhalter@amazon.com> * updated screen shots and fixed links Signed-off-by: Heather Halter <hdhalter@amazon.com> * fix links Signed-off-by: Heather Halter <hdhalter@amazon.com> * remove strange character Signed-off-by: Heather Halter <hdhalter@amazon.com> * Update _security-analytics/index.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _security-analytics/usage/findings.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _security-analytics/sec-analytics-config/detectors-config.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _security-analytics/sec-analytics-config/detectors-config.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _security-analytics/usage/findings.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * fixed substep formatting problem Signed-off-by: Heather Halter <hdhalter@amazon.com> * Update _security-analytics/sec-analytics-config/detectors-config.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> --------- Signed-off-by: Heather Halter <hdhalter@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com>

detector draft

53243b3

Signed-off-by: Heather Halter <hdhalter@amazon.com>

hdhalter requested review from kolchfa-aws, Naarcha-AWS, vagimeli, ananzh, seanneumann, AMoo-Miki and natebower as code owners October 9, 2023 19:30

hdhalter self-assigned this Oct 9, 2023

hdhalter marked this pull request as draft October 9, 2023 20:04

hdhalter added 3 commits October 9, 2023 13:56

updated screen shots and fixed links

0cf0640

Signed-off-by: Heather Halter <hdhalter@amazon.com>

fix links

e23b201

Signed-off-by: Heather Halter <hdhalter@amazon.com>

remove strange character

83ef668

Signed-off-by: Heather Halter <hdhalter@amazon.com>

hdhalter marked this pull request as ready for review October 9, 2023 21:20

hdhalter added 3 - Tech review PR: Tech review in progress v2.11.0 release-notes PR: Include this PR in the automated release notes labels Oct 9, 2023

sbcd90 approved these changes Oct 11, 2023

View reviewed changes

amsiglan reviewed Oct 11, 2023

View reviewed changes

_security-analytics/sec-analytics-config/detectors-config.md Outdated Show resolved Hide resolved

amsiglan reviewed Oct 11, 2023

View reviewed changes

_security-analytics/sec-analytics-config/detectors-config.md Outdated Show resolved Hide resolved

hdhalter added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Oct 11, 2023

Naarcha-AWS reviewed Oct 12, 2023

View reviewed changes

_security-analytics/index.md Outdated Show resolved Hide resolved

Naarcha-AWS reviewed Oct 12, 2023

View reviewed changes

_security-analytics/usage/findings.md Show resolved Hide resolved

Naarcha-AWS approved these changes Oct 12, 2023

View reviewed changes

hdhalter and others added 2 commits October 12, 2023 13:04

Update _security-analytics/index.md

237c595

Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

Update _security-analytics/usage/findings.md

4bb7ebe

Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

hdhalter added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Oct 12, 2023

natebower reviewed Oct 12, 2023

View reviewed changes

hdhalter and others added 3 commits October 12, 2023 13:44

Update _security-analytics/sec-analytics-config/detectors-config.md

a9ef357

Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

Update _security-analytics/sec-analytics-config/detectors-config.md

d34bfee

Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

Update _security-analytics/usage/findings.md

e5f45e2

Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

fixed substep formatting problem

c510c4b

Signed-off-by: Heather Halter <hdhalter@amazon.com>

natebower approved these changes Oct 13, 2023

View reviewed changes

_security-analytics/sec-analytics-config/detectors-config.md Outdated Show resolved Hide resolved

Update _security-analytics/sec-analytics-config/detectors-config.md

88ece77

Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

hdhalter merged commit 346c52d into main Oct 13, 2023
3 checks passed

hdhalter removed the 5 - Editorial review PR: Editorial review in progress label Oct 13, 2023

vagimeli added a commit that referenced this pull request Oct 13, 2023

Revert "Add updates to creating a detector UX (#5176)"

26ff5db

This reverts commit f3007fc.

vagimeli added a commit that referenced this pull request Oct 13, 2023

Revert "Add updates to creating a detector UX (#5176)"

1a40493

This reverts commit f3007fc. Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

vagimeli added a commit that referenced this pull request Oct 13, 2023

Revert "Add updates to creating a detector UX (#5176)"

c384b10

This reverts commit f3007fc. Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

vagimeli added a commit that referenced this pull request Oct 13, 2023

Revert "Revert "Add updates to creating a detector UX (#5176)""

dc8b2cc

This reverts commit c384b10.

hdhalter deleted the sec-analytics-211 branch March 28, 2024 21:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add updates to creating a detector UX #5176

Add updates to creating a detector UX #5176

hdhalter commented Oct 9, 2023 •

edited

Loading

hdhalter commented Oct 9, 2023

Naarcha-AWS left a comment

natebower left a comment

hdhalter commented Oct 12, 2023

hdhalter commented Oct 12, 2023

natebower left a comment

hdhalter commented Oct 13, 2023

Add updates to creating a detector UX #5176

Add updates to creating a detector UX #5176

Conversation

hdhalter commented Oct 9, 2023 • edited Loading

Description

Issues Resolved

Checklist

hdhalter commented Oct 9, 2023

Naarcha-AWS left a comment

Choose a reason for hiding this comment

natebower left a comment

Choose a reason for hiding this comment

hdhalter commented Oct 12, 2023

hdhalter commented Oct 12, 2023

natebower left a comment

Choose a reason for hiding this comment

hdhalter commented Oct 13, 2023

hdhalter commented Oct 9, 2023 •

edited

Loading