Updating documentation for new datetime format #6337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaptainDredge
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower and
dlvenable
as code owners
4 tasks
|
Thanks, @CaptainDredge ! Did you mean to link this to issue #6308? Is the content ready for doc review? |
Thanks @hdhalter I've linked to the right issue. The content is ready for review but I'm not able to figure out what exact formatting is required for CI to go green. Is there any automated linter for the docs? |
hdhalter
added
4 - Doc Review
Naarcha-AWS
requested changes
Feb 5, 2024
Signed-off-by: Prabhat Sharma <ptsharma@amazon.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Prabhat <20185657+CaptainDredge@users.noreply.github.com>
Naarcha-AWS
approved these changes
Feb 6, 2024
Naarcha-AWS
added
6 - Done but waiting to merge
|
Moving to done, we should update Vale rules so that an |
|
Endash is required in text but this is literal strings so they should be in code format. Let me make some suggestions. |
kolchfa-aws
reviewed
Feb 6, 2024
There was a problem hiding this comment.
Looking at this, we should change all string literals to have code format. @CaptainDredge If you'd like to take this on, that would be great. Otherwise, we can address this in a separate issue. Thanks!
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Naarcha-AWS
reviewed
Feb 8, 2024
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
hdhalter
added
3 - Done
oeyh
pushed a commit
to oeyh/documentation-website
that referenced
this pull request
Mar 14, 2024
* Updating documentation for new datetime format introduced in OS 2.12 Signed-off-by: Prabhat Sharma <ptsharma@amazon.com> * Update _field-types/supported-field-types/date.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Prabhat <20185657+CaptainDredge@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Update date.md Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> --------- Signed-off-by: Prabhat Sharma <ptsharma@amazon.com> Signed-off-by: Prabhat <20185657+CaptainDredge@users.noreply.github.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Prabhat Sharma <ptsharma@amazon.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates documentation for new datetime format
rfc_3339_lenientIssues Resolved
Closes #6308
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.