Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding missing Lucene versions #7130

Merged
merged 4 commits into from
May 21, 2024
Merged

Adding missing Lucene versions #7130

merged 4 commits into from
May 21, 2024

Conversation

dtaivpp
Copy link
Contributor

@dtaivpp dtaivpp commented May 10, 2024

Description

Hey all, noticed the upgrade page was missing several releases of OpenSearch and their respective lucene versions. Added those in. Also, creating an issue to automate this as we should be able to pull these from the dependencies files.

Issues Resolved

N/A

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@hdhalter hdhalter added the 3 - Tech Review PR: Tech review in progress label May 10, 2024
@hdhalter
Copy link
Collaborator

Thanks, @dtaivpp!

msfroh
msfroh reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@msfroh msfroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to find a good reference for the corresponding Elasticsearch versions (besides jumping through their release notes).

Do we need to include recent Elasticsearch versions in this table? As far as I know, we make no claims of compatibility after Elasticsearch 7.10.

_install-and-configure/upgrade-opensearch/index.md Show resolved Hide resolved
_install-and-configure/upgrade-opensearch/index.md Show resolved Hide resolved
@dtaivpp
Copy link
Contributor Author

dtaivpp commented May 10, 2024

@msfroh Yeah I feel like we can stop including it. I hopped release notes but it's mostly just for reference. I think safe to leave them out past here.

dtaivpp and others added 2 commits May 13, 2024 09:52
@dtaivpp
Adding missing Lucene versions. Also, I will create an issue to autom…
a50c950 
…ate this

Signed-off-by: David Tippett <dtaivpp@gmail.com>
@dtaivpp
Update index.md
88eac0f 
Signed-off-by: David Tippett <dtaivpp@gmail.com>
@hdhalter
Copy link
Collaborator

Hi David, thanks so much for adding this and it's good to see you! Is the content ready for a doc review?

dtaivpp and others added 2 commits May 21, 2024 10:43
@dtaivpp
Merge branch 'opensearch-project:main' into main
3e71d23
@dtaivpp
Adding 2.14.0
ecb658c 
Signed-off-by: David Tippett <dtaivpp@gmail.com>
@dtaivpp
Copy link
Contributor Author

dtaivpp commented May 21, 2024

@hdhalter thanks for your patience! All ready for doc review. I added 2.14 in too

@hdhalter
Copy link
Collaborator

@msfroh - Are you good with this? Thanks!

@msfroh
Copy link
Contributor

msfroh commented May 21, 2024

Looks good to me 👍

Thanks again @dtaivpp !

@hdhalter hdhalter added the backport 2.14 PR: Backport label for 2.14 label May 21, 2024
@hdhalter hdhalter removed the backport 2.14 PR: Backport label for 2.14 label May 21, 2024
@hdhalter hdhalter merged commit b0edb37 into opensearch-project:main May 21, 2024
8 checks passed
@hdhalter hdhalter added the backport 2.14 PR: Backport label for 2.14 label May 21, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 21, 2024
@github-actions
Adding missing Lucene versions (#7130)
8507233 
* Adding missing Lucene versions. Also, I will create an issue to automate this

Signed-off-by: David Tippett <dtaivpp@gmail.com>

* Update index.md

Signed-off-by: David Tippett <dtaivpp@gmail.com>

* Adding 2.14.0

Signed-off-by: David Tippett <dtaivpp@gmail.com>

---------

Signed-off-by: David Tippett <dtaivpp@gmail.com>
(cherry picked from commit b0edb37)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 21, 2024
Merged
github-actions bot pushed a commit that referenced this pull request May 21, 2024
@opensearch-trigger-bot
Adding missing Lucene versions (#7130) (#7220)
1046d45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfroh msfroh msfroh approved these changes

@hdhalter hdhalter hdhalter approved these changes

@kolchfa-aws kolchfa-aws Awaiting requested review from kolchfa-aws kolchfa-aws is a code owner

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@vagimeli vagimeli Awaiting requested review from vagimeli vagimeli is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@natebower natebower Awaiting requested review from natebower natebower is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@scrawfor99 scrawfor99 Awaiting requested review from scrawfor99 scrawfor99 is a code owner

@epugh epugh Awaiting requested review from epugh epugh is a code owner

Assignees
No one assigned
Labels
3 - Tech Review PR: Tech review in progress backport 2.14 PR: Backport label for 2.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtaivpp @hdhalter @msfroh