Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Create a new Util method for a common pattern #720

Closed
owaiskazi19 opened this issue May 30, 2024 · 4 comments · Fixed by #721
Closed

[FEATURE] Create a new Util method for a common pattern #720

owaiskazi19 opened this issue May 30, 2024 · 4 comments · Fixed by #721
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@owaiskazi19
Copy link
Member

owaiskazi19 commented May 30, 2024

Is your feature request related to a problem?

We have the below pattern in couple of WorkflowSteps in the codebase

inputs.containsKey(foo) ? Booleans.parseBoolean(inputs.get(foo).toString()) : null

This can be refactored into a util method to avoid duplication.

What solution would you like?

Create a Util method in ParseUtils.java file, have the above code in it. Invoke the util method everywhere where the above pattern is found.

What alternatives have you considered?

Keep it as it is

Do you have any additional context?

Add any other context or screenshots about the feature request here.

@dbwiddis
Copy link
Member

@martinpkr can you comment on this issue so we can assign it to you?

@martinpkr
Copy link
Contributor

martinpkr commented May 30, 2024 via email

@dbwiddis
Copy link
Member

Will do in 20-25 minutes!

You just did, haha!

@martinpkr
Copy link
Contributor

martinpkr commented May 30, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
3 participants