[Backport 2.x] Adding default use cases #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* initial default use case addition Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * adding IT and UT Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * addresing comments and adding more tests Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * addressing more comments and adding more UT Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * addressed more comments and more UT Signed-off-by: Amit Galitzky <amgalitz@amazon.com> --------- Signed-off-by: Amit Galitzky <amgalitz@amazon.com> (cherry picked from commit b148eb5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
owaiskazi19
approved these changes
Mar 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #587 +/- ##
============================================
+ Coverage 72.55% 72.76% +0.21%
- Complexity 659 680 +21
============================================
Files 80 81 +1
Lines 3399 3466 +67
Branches 268 278 +10
============================================
+ Hits 2466 2522 +56
- Misses 816 826 +10
- Partials 117 118 +1 ☔ View full report in Codecov by Sentry. |
amitgalitz
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b148eb5 from #583.