Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test, testIndexingMultiPolygon #294 #301

Closed
wants to merge 1 commit into from
Closed

Fix flaky test, testIndexingMultiPolygon #294 #301

wants to merge 1 commit into from
+434 −5

Conversation

heemin32
Copy link
Collaborator

Description

Fix flaky test, testIndexingMultiPolygon #294

Issues Resolved

#294

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@heemin32 heemin32 added backport 2.x Backport PR to 2.x branch skip-changelog labels May 10, 2023
@heemin32
Copy link
Collaborator Author

Test is still failing because lucene test framework has a bug. Either we need to implement it ourselves or fix the bug in lucene repo.
https://github.com/apache/lucene/blob/main/lucene/test-framework/src/java/org/apache/lucene/tests/geo/ShapeTestUtil.java#L97

@navneet1v
Copy link
Collaborator

Test is still failing because lucene test framework has a bug. Either we need to implement it ourselves or fix the bug in lucene repo. https://github.com/apache/lucene/blob/main/lucene/test-framework/src/java/org/apache/lucene/tests/geo/ShapeTestUtil.java#L97

what is the bug?

@heemin32
Copy link
Collaborator Author

Test is still failing because lucene test framework has a bug. Either we need to implement it ourselves or fix the bug in lucene repo. https://github.com/apache/lucene/blob/main/lucene/test-framework/src/java/org/apache/lucene/tests/geo/ShapeTestUtil.java#L97

what is the bug?

apache/lucene#12287

@heemin32
Fix flaky test, testIndexingMultiPolygon opensearch-project#294
144ba17 
Signed-off-by: Heemin Kim <heemin@amazon.com>
@heemin32 heemin32 closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VijayanB VijayanB VijayanB approved these changes

@navneet1v navneet1v Awaiting requested review from navneet1v navneet1v is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@jmazanec15 jmazanec15 Awaiting requested review from jmazanec15 jmazanec15 is a code owner

@naveentatikonda naveentatikonda Awaiting requested review from naveentatikonda naveentatikonda is a code owner

@junqiu-lei junqiu-lei Awaiting requested review from junqiu-lei junqiu-lei is a code owner

@martin-gaievski martin-gaievski Awaiting requested review from martin-gaievski martin-gaievski is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport PR to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heemin32 @navneet1v @VijayanB