[BUG][opensearch] log4j2.properties in values.yaml does not work with toYaml in configmap.yaml

[sastorsl]

Describe the bug
In the current chart for opensearch-dashboards it is not possible to template log4j2.properties as the configmap.yaml expects input to be in yaml.
log4j2.properties is not yaml but has a key = value structure.

This makes it not possible to override the log4j configuration with the current chart.

To Reproduce
Steps to reproduce the behavior:

1. Add helm repo
2. Edit values.yaml and add log4j2.properties to config
3. helm install
4. See error, which is that the file is created without line breaks, which renders it unusable.

This happens because the log4j2.properties is not YAML, but rather key = value.
Any yaml multiline trick does not work.

Error message from pod:

2021-10-28 12:28:14,202 main ERROR Invalid status level specified: ERROR APPENDER.CONSOLE.TYPE = CONSOLE APPENDER.CONSOLE.NAME = CONSOLE APPENDER.CONSOLE.LAYOUT.TYPE. Defaulting to ERROR.

Expected behavior
log4j2.properties to be created in a proper format.

Chart Name
opensearch - configmap

https://github.com/opensearch-project/helm-charts/blob/main/charts/opensearch/templates/configmap.yaml#L11 - toYaml

Screenshots

Example config in values.yaml

config:
  log4j2.properties:
    status = error
    appender.console.type = Console
    appender.console.name = console
    appender.console.layout.type = PatternLayout
    appender.console.layout.pattern = [%d{ISO8601}][%-5p][%-25c{1.}] [%node_name]%marker %m%n
    rootLogger.level = info
    rootLogger.appenderRef.console.ref = console
    logger.plugins.security.name = com.amazon.dlic.auth.http.jwt
    logger.plugins.security.level = trace

Output from helm install

config:
  log4j2.properties: status = error appender.console.type = Console appender.console.name
    = console appender.console.layout.type = PatternLayout appender.console.layout.pattern
    = [%d{ISO8601}][%-5p][%-25c{1.}] [%node_name]%marker %m%n rootLogger.level = info
    rootLogger.appenderRef.console.ref = console logger.plugins.security.name = com.amazon.dlic.auth.http.jwt
    logger.plugins.security.level = trace

configmap:

data:
  log4j2.properties: |
    status = error appender.console.type = Console appender.console.name = console appender.console.layout.type
      = PatternLayout appender.console.layout.pattern = [%d{ISO8601}][%-5p][%-25c{1.}]
      [%node_name]%marker %m%n rootLogger.level = info rootLogger.appenderRef.console.ref
      = console logger.plugins.security.name = com.amazon.dlic.auth.http.jwt logger.plugins.security.level
      = trace

Resulting file:

$ k exec -ti opensearch-1 -- bash -c "cat config/log4j2.properties"
status = error appender.console.type = Console appender.console.name = console appender.console.layout.type
  = PatternLayout appender.console.layout.pattern = [%d{ISO8601}][%-5p][%-25c{1.}]
  [%node_name]%marker %m%n rootLogger.level = info rootLogger.appenderRef.console.ref
  = console logger.plugins.security.name = com.amazon.dlic.auth.http.jwt logger.plugins.security.level
  = trace

Host/Environment (please complete the following information):

• Helm Version: 3.7.0
• Kubernetes Version: 1.21.2

Additional context
Workaround would probably be to create a separate configmap and reference, but using it in values.config should also work.

[sastorsl]

This diff handles log4j

diff --git a/charts/opensearch/templates/configmap.yaml b/charts/opensearch/templates/configmap.yaml
index af50771..364ee9c 100644
--- a/charts/opensearch/templates/configmap.yaml
+++ b/charts/opensearch/templates/configmap.yaml
@@ -7,7 +7,12 @@ metadata:
     {{- include "opensearch.labels" . | nindent 4 }}
 data:
 {{- range $configName, $configYaml := .Values.config }}
+  {{- if eq $configName "log4j2.properties" }}
+  {{ $configName }}: |
+    {{- $configYaml | nindent 4 }}
+  {{- else }}
   {{ $configName }}: |
     {{- toYaml $configYaml | nindent 4 }}
+  {{- end -}}
 {{- end -}}
 {{- end -}}