[Backport 2.x] Error Prevention: Add close action #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Error Prevention: Add close action Signed-off-by: Angie Zhang <langelzh@amazon.com> * Error Prevention: Add close action Signed-off-by: Angie Zhang <langelzh@amazon.com> * Error Prevention: Add close action Signed-off-by: Angie Zhang <langelzh@amazon.com> * Error Prevention: Add close action Signed-off-by: Angie Zhang <langelzh@amazon.com> * Fixed comments for close action validation. Signed-off-by: Angie Zhang <langelzh@amazon.com> * Added return false for validIndex method Signed-off-by: Angie Zhang <langelzh@amazon.com> * Updated test case name Signed-off-by: Angie Zhang <langelzh@amazon.com> --------- Signed-off-by: Angie Zhang <langelzh@amazon.com> (cherry picked from commit 363086f)
Angie-Zhang
approved these changes
Apr 14, 2023
AWSHurneyt
approved these changes
Apr 14, 2023
ronnaksaxena
pushed a commit
to ronnaksaxena/index-management
that referenced
this pull request
Jul 19, 2023
…ch-project#749) * Error Prevention: Add close action Signed-off-by: Angie Zhang <langelzh@amazon.com> * Error Prevention: Add close action Signed-off-by: Angie Zhang <langelzh@amazon.com> * Error Prevention: Add close action Signed-off-by: Angie Zhang <langelzh@amazon.com> * Error Prevention: Add close action Signed-off-by: Angie Zhang <langelzh@amazon.com> * Fixed comments for close action validation. Signed-off-by: Angie Zhang <langelzh@amazon.com> * Added return false for validIndex method Signed-off-by: Angie Zhang <langelzh@amazon.com> * Updated test case name Signed-off-by: Angie Zhang <langelzh@amazon.com> --------- Signed-off-by: Angie Zhang <langelzh@amazon.com> (cherry picked from commit 363086f) Co-authored-by: Angie Zhang <langelzh@amazon.com> Signed-off-by: Ronnak Saxena <ronsax@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 363086f from #728