Update CI to use jdk-21 (#1288)

This updates the CI system to use jdk-21, which is latest LTS supported version.
Coming from opensearch-project/OpenSearch#10334

Signed-off-by: John Mazanec <jmazane@amazon.com>
(cherry picked from commit c72f096)

.github/workflows/CI.yml

@@ -20,7 +20,7 @@ jobs:
   Build-k-NN-Linux:
     strategy:
       matrix:
-        java: [11, 17]
+        java: [11, 17, 21]
 
     name: Build and Test k-NN Plugin on Linux
     runs-on: ubuntu-latest
@@ -57,7 +57,7 @@ jobs:
   Build-k-NN-MacOS:
     strategy:
       matrix:
-        java: [ 11, 17 ]
+        java: [ 11, 17, 21 ]
 
     name: Build and Test k-NN Plugin on MacOS
     needs: Get-CI-Image-Tag
@@ -84,7 +84,7 @@ jobs:
   Build-k-NN-Windows:
     strategy:
       matrix:
-        java: [ 11, 17 ]
+        java: [ 11, 17, 21 ]
 
     name: Build and Test k-NN Plugin on Windows
     needs: Get-CI-Image-Tag

.github/workflows/test_security.yml

@@ -15,7 +15,7 @@ jobs:
   Build-ad:
     strategy:
       matrix:
-        java: [ 11,17 ]
+        java: [ 11,17,21 ]
         os: [ubuntu-latest]
       fail-fast: true
 

build.gradle

@@ -36,7 +36,7 @@ plugins {
     id 'java-library'
     id 'java-test-fixtures'
     id 'idea'
-    id "com.diffplug.spotless" version "6.3.0" apply false
+    id "com.diffplug.spotless" version "6.20.0" apply false
     id 'io.freefair.lombok' version '8.4'
 }
 

src/main/java/org/opensearch/knn/indices/ModelDao.java

@@ -654,7 +654,9 @@ private void removeModelIdFromGraveyardOnFailure(String modelId, Exception excep
             client.execute(
                 UpdateModelGraveyardAction.INSTANCE,
                 new UpdateModelGraveyardRequest(modelId, true),
-                ActionListener.wrap(acknowledgedResponse -> { throw exceptionFromPreviousStep; }, unblockingFailedException -> {
+                ActionListener.wrap(acknowledgedResponse -> {
+                    throw exceptionFromPreviousStep;
+                }, unblockingFailedException -> {
                     // If it fails to remove the modelId from Model Graveyard, then log the error message and
                     // throw the exception that was passed as a parameter from previous step
                     String errorMessage = String.format("Failed to remove \" %s \" from Model Graveyard", modelId);

src/testFixtures/java/org/opensearch/knn/TestUtils.java

@@ -208,12 +208,9 @@ public static PriorityQueue<DistVector> computeGroundTruthValues(int k, SpaceTyp
     public static float computeDistFromSpaceType(SpaceType spaceType, float[] indexVector, float[] queryVector) {
         float dist;
         if (spaceType != null) {
-            dist = KNN_SCORING_SPACE_TYPE.getOrDefault(
-                spaceType,
-                (defaultQueryVector, defaultIndexVector) -> {
-                    throw new IllegalArgumentException(String.format("Invalid SpaceType function: \"%s\"", spaceType));
-                }
-            ).apply(queryVector, indexVector);
+            dist = KNN_SCORING_SPACE_TYPE.getOrDefault(spaceType, (defaultQueryVector, defaultIndexVector) -> {
+                throw new IllegalArgumentException(String.format("Invalid SpaceType function: \"%s\"", spaceType));
+            }).apply(queryVector, indexVector);
         } else {
             throw new NullPointerException("SpaceType is null. Provide a valid SpaceType.");
         }