Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise gcc version requirement to 9.0.0 for SIMD Neon support on ARM64 #1517

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Raise gcc version requirement to 9.0.0 for SIMD Neon support on ARM64 #1517

merged 1 commit into from
Mar 7, 2024

Conversation

peterzhuamazon
Copy link
Member

Description

Raise gcc version requirement to 9.0.0 for SIMD Neon support on ARM64

Issues Resolved

Part of opensearch-project/opensearch-build#4386

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon
Raise gcc version requirement to 9.0.0 for SIMD Neon support on ARM64
b4b30e6 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon added Enhancements Increases software capabilities beyond original client specifications enhancement backport 2.x labels Mar 6, 2024
@peterzhuamazon peterzhuamazon self-assigned this Mar 6, 2024
This was referenced Mar 6, 2024
Merged
Closed
@peterzhuamazon
Copy link
Member Author

Awaiting:

@peterzhuamazon peterzhuamazon marked this pull request as draft March 6, 2024 23:46
@jmazanec15
Copy link
Member

We will also need to remove https://github.com/opensearch-project/k-NN/pull/1517/files#diff-3d64996115d0ac3b74e36f57ce6b00d6b4982614c41b1ed39eab8ef43b2e9a2bL98-L101. But I think that can be taken for another change.

@codecov Codecov
Copy link

codecov bot commented Mar 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.09%. Comparing base (1303182) to head (b4b30e6).

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #1517   +/-   ##
=========================================
  Coverage     85.09%   85.09%           
  Complexity     1280     1280           
=========================================
  Files           168      168           
  Lines          5232     5232           
  Branches        495      495           
=========================================
  Hits           4452     4452           
  Misses          572      572           
  Partials        208      208

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterzhuamazon peterzhuamazon marked this pull request as ready for review March 7, 2024 23:09
@peterzhuamazon
Copy link
Member Author

Image online: https://hub.docker.com/r/opensearchstaging/ci-runner/tags?page=1&ordering=last_updated&name=ci-runner-centos7-opensearch-build-v3.9

@peterzhuamazon peterzhuamazon merged commit 7a144b8 into opensearch-project:main Mar 7, 2024
24 of 73 checks passed
@peterzhuamazon peterzhuamazon deleted the change-gcc-restrictions branch March 7, 2024 23:09
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 7, 2024
@peterzhuamazon @github-actions
Raise gcc version requirement to 9.0.0 for SIMD Neon support on ARM64 (…
fdb5cf8 
…#1517)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
(cherry picked from commit 7a144b8)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 7, 2024
Merged
peterzhuamazon added a commit that referenced this pull request Mar 7, 2024
@opensearch-trigger-bot @peterzhuamazon
Raise gcc version requirement to 9.0.0 for SIMD Neon support on ARM64 (…
65545a3 
…#1517) (#1523)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
(cherry picked from commit 7a144b8)

Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon mentioned this pull request Apr 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmazanec15 jmazanec15 jmazanec15 approved these changes

@naveentatikonda naveentatikonda naveentatikonda approved these changes

@heemin32 heemin32 Awaiting requested review from heemin32 heemin32 is a code owner

@navneet1v navneet1v Awaiting requested review from navneet1v navneet1v is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@junqiu-lei junqiu-lei Awaiting requested review from junqiu-lei junqiu-lei is a code owner

@martin-gaievski martin-gaievski Awaiting requested review from martin-gaievski martin-gaievski is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan ryanbogan is a code owner

Assignees

@peterzhuamazon peterzhuamazon

Labels
backport 2.x enhancement Enhancements Increases software capabilities beyond original client specifications skip-changelog
Projects
OpenSearch Engineering Effectiveness
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterzhuamazon @jmazanec15 @naveentatikonda