Add faiss custom patch to support search parameter in binary index #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heemin Kim <heemin@amazon.com>
heemin32
requested review from
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
navneet1v
approved these changes
Jul 11, 2024
jmazanec15
approved these changes
Jul 11, 2024
heemin32
merged commit f4a84d6
into
opensearch-project:feature/binary-format
51 of 63 checks passed
naveentatikonda
pushed a commit
that referenced
this pull request
Jul 12, 2024
…1815) Signed-off-by: Heemin Kim <heemin@amazon.com>
5 tasks
heemin32
added a commit
that referenced
this pull request
Jul 16, 2024
…n Faiss Engine (#1829) * Add faiss custom patch to support search parameter in binary index (#1815) Signed-off-by: Heemin Kim <heemin@amazon.com> * Add binary format support with HNSW method in Faiss Engine (#1781) Signed-off-by: Heemin Kim <heemin@amazon.com> --------- Signed-off-by: Heemin Kim <heemin@amazon.com>
heemin32
added a commit
to heemin32/k-NN
that referenced
this pull request
Jul 16, 2024
…n Faiss Engine (opensearch-project#1829) * Add faiss custom patch to support search parameter in binary index (opensearch-project#1815) Signed-off-by: Heemin Kim <heemin@amazon.com> * Add binary format support with HNSW method in Faiss Engine (opensearch-project#1781) Signed-off-by: Heemin Kim <heemin@amazon.com> --------- Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit fe1d86f)
heemin32
added a commit
that referenced
this pull request
Jul 16, 2024
…n Faiss Engine (#1829) (#1834) * Add faiss custom patch to support search parameter in binary index (#1815) Signed-off-by: Heemin Kim <heemin@amazon.com> * Add binary format support with HNSW method in Faiss Engine (#1781) Signed-off-by: Heemin Kim <heemin@amazon.com> --------- Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit fe1d86f)
ryanbogan
pushed a commit
to ryanbogan/k-NN
that referenced
this pull request
Jul 16, 2024
…n Faiss Engine (opensearch-project#1829) * Add faiss custom patch to support search parameter in binary index (opensearch-project#1815) Signed-off-by: Heemin Kim <heemin@amazon.com> * Add binary format support with HNSW method in Faiss Engine (opensearch-project#1781) Signed-off-by: Heemin Kim <heemin@amazon.com> --------- Signed-off-by: Heemin Kim <heemin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add faiss custom patch to support search parameter in binary index
Please see the patch as plain file at heemin32/faiss@4d374aa
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.