Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Baseline Maintainers (#883) #890

Merged

Conversation

naveentatikonda
Copy link
Member

Description

Cherry-picked from #883

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2023

Codecov Report

Merging #890 (a1c3ba9) into 2.x (bfb9078) will increase coverage by 0.01%.
The diff coverage is 90.90%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x     #890      +/-   ##
============================================
+ Coverage     85.05%   85.07%   +0.01%     
+ Complexity     1093     1088       -5     
============================================
  Files           153      152       -1     
  Lines          4423     4414       -9     
  Branches        395      392       -3     
============================================
- Hits           3762     3755       -7     
  Misses          482      482              
+ Partials        179      177       -2     
Impacted Files Coverage Δ
...n/plugin/transport/SearchModelTransportAction.java 75.00% <50.00%> (-6.82%) ⬇️
...plugin/transport/TrainingModelTransportAction.java 84.84% <75.00%> (-1.27%) ⬇️
...main/java/org/opensearch/knn/indices/ModelDao.java 82.67% <94.44%> (+1.19%) ⬆️
...n/plugin/transport/DeleteModelTransportAction.java 100.00% <100.00%> (ø)
.../knn/plugin/transport/GetModelTransportAction.java 100.00% <100.00%> (ø)
...in/transport/TrainingJobRouterTransportAction.java 80.00% <100.00%> (-0.86%) ⬇️

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@naveentatikonda naveentatikonda merged commit 485a748 into opensearch-project:2.x May 4, 2023
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants