restore thread context before running action listener #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dhrubo-os
reviewed
Oct 3, 2023
| @@ -225,14 +225,14 @@ void registerModel(ActionListener<MLRegisterModelResponse> listener) throws Inte | |||
| XContentBuilder builder = XContentBuilder.builder(XContentType.JSON.xContent()); | |||
| modelGroup.toXContent(builder, ToXContent.EMPTY_PARAMS); | |||
| createModelGroupRequest.source(builder); | |||
| client.index(createModelGroupRequest, ActionListener.wrap(r -> { | |||
| client.index(createModelGroupRequest, ActionListener.runBefore(ActionListener.wrap(r -> { | |||
There was a problem hiding this comment.
May be we should add a similar comment in the code also what you have in the PR?
Codecov Report
@@ Coverage Diff @@
## 2.9 #1418 +/- ##
============================================
+ Coverage 78.72% 78.76% +0.03%
- Complexity 2140 2153 +13
============================================
Files 168 168
Lines 8756 8767 +11
Branches 878 878
============================================
+ Hits 6893 6905 +12
+ Misses 1463 1462 -1
Partials 400 400
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dhrubo-os
approved these changes
Oct 3, 2023
rbhavna
approved these changes
Oct 3, 2023
5 tasks
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Oct 3, 2023
…ject#1418) Signed-off-by: Yaliang Wu <ylwu@amazon.com>
5 tasks
ylwu-amzn
added a commit
that referenced
this pull request
Oct 3, 2023
TrungBui59
pushed a commit
to TrungBui59/ml-commons
that referenced
this pull request
Nov 21, 2023
…ject#1418) (opensearch-project#1422) (opensearch-project#1435) Signed-off-by: Yaliang Wu <ylwu@amazon.com> (cherry picked from commit 9359487) Co-authored-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: TrungBui59 <bui23@purdue.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We see reindex will throw error "wrong user in reader context". That's because after stashing thread context, the user info will be gone. Security plugin will recheck user info when reindex, then throw this error. We should restore thread context before running action listener.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.