Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lombok and Gradle plugins to support JDK-21 #1698

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

reta
Copy link
Contributor

@reta reta commented Nov 27, 2023

Description

Update Lombok and Gradle plugins to support JDK-21

Issues Resolved

> java.lang.NoSuchFieldError: Class com.sun.tools.javac.tree.JCTree$JCImport does not have member field 'com.sun.tools.javac.tree.JCTree qualid'

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (500fff9) 80.84% compared to head (2d83ddb) 80.85%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1698      +/-   ##
============================================
+ Coverage     80.84%   80.85%   +0.01%     
- Complexity     4215     4217       +2     
============================================
  Files           404      404              
  Lines         16977    16977              
  Branches       1818     1818              
============================================
+ Hits          13725    13727       +2     
+ Misses         2539     2536       -3     
- Partials        713      714       +1     
Flag Coverage Δ
ml-commons 80.85% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ylwu-amzn
Copy link
Collaborator

@reta The JDK 21 Github CI failed

@reta
Copy link
Contributor Author

reta commented Nov 28, 2023

@reta The JDK 21 Github CI failed

@ylwu-amzn The build is back on track but the tests were and are still unstable (it pre-dates any recent Gradle or JDK updates). I haven't seen a single pull request that passed the checks in this repository for a loooong time, so I have no idea is that JDK-21 related or just flaky ones. Could you please retrigger failed GA actions? (I sadly have no permissions)

@reta reta temporarily deployed to ml-commons-cicd-env November 28, 2023 04:30 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env November 28, 2023 04:30 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env November 28, 2023 04:30 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env November 28, 2023 04:30 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env November 28, 2023 23:50 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env November 28, 2023 23:50 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env November 28, 2023 23:50 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env November 28, 2023 23:50 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env November 29, 2023 00:27 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env November 29, 2023 00:27 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env November 29, 2023 00:27 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env November 29, 2023 00:27 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env November 29, 2023 00:27 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env November 29, 2023 00:27 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os merged commit df644ff into opensearch-project:main Nov 29, 2023
14 of 17 checks passed
@reta reta temporarily deployed to ml-commons-cicd-env November 29, 2023 22:04 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env November 29, 2023 22:04 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env November 29, 2023 22:04 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env November 29, 2023 22:04 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env November 29, 2023 22:04 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env November 29, 2023 22:04 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env November 29, 2023 22:04 — with GitHub Actions Inactive
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1698-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 df644ffecc1d5dd60ffc985a4c1aa69a947f2d79
# Push it to GitHub
git push --set-upstream origin backport/backport-1698-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1698-to-2.x.

@reta
Copy link
Contributor Author

reta commented Nov 29, 2023

Backported by #1697

austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants