Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve hosts when checking against host deny list #496

Merged
merged 7 commits into from
Aug 5, 2022
Merged

Resolve hosts when checking against host deny list #496

merged 7 commits into from
Aug 5, 2022

Commits on Aug 1, 2022

  1. Resolve hosts when checking against host deny list 

    Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
    @qreshi
    qreshi committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    6ff99c0 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. Stub isHostInDenyList() for notification core unit tests 

    Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
    @qreshi
    qreshi committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    62a63d1 View commit details
    Browse the repository at this point in the history

  2. Stub the correct isHostInDenylist function 

    Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
    @qreshi
    qreshi committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    73de828 View commit details
    Browse the repository at this point in the history

  3. Use Before annotation instead for mocking setup 

    Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
    @qreshi
    qreshi committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    0fad996 View commit details
    Browse the repository at this point in the history

  4. Test switching one of the ChimeDestinationTests to use mockk instead … 

    …of EasyMock

Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
    @qreshi
    qreshi committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    fa1ab61 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. Switch to BeforeEach for setup and remove unneeded unit test 

    Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
    @qreshi
    qreshi committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    5827c3c View commit details
    Browse the repository at this point in the history

  2. Change CustomWebhookDestinationTest and SlackDestinationTests to use … 

    …BeforeEach as well for consistency

Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
    @qreshi
    qreshi committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    ac9cc63 View commit details
    Browse the repository at this point in the history