Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable following redirects for webhooks #507

Merged
merged 1 commit into from Aug 18, 2022

Conversation

qreshi
Copy link
Contributor

@qreshi qreshi commented Aug 17, 2022

Signed-off-by: Mohammad Qureshi 47198598+qreshi@users.noreply.github.com

Description

Disabling redirect handling for the HttpClient used when sending Notifications.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022

Codecov Report

Merging #507 (48ea622) into main (82a926e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #507      +/-   ##
============================================
+ Coverage     61.43%   61.45%   +0.01%     
  Complexity      112      112              
============================================
  Files            73       73              
  Lines          2466     2467       +1     
  Branches        266      266              
============================================
+ Hits           1515     1516       +1     
  Misses          773      773              
  Partials        178      178              
Flag Coverage Δ
opensearch-notifications 61.45% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...notifications/core/client/DestinationHttpClient.kt 86.76% <100.00%> (+0.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lezzago
Copy link
Member

lezzago commented Aug 17, 2022

The current failure is due to an existing cypress test failure that failed in previous commits as well. That failure will be looked at separately.

@lezzago lezzago marked this pull request as ready for review August 18, 2022 17:02
@lezzago lezzago requested a review from a team August 18, 2022 17:02
@lezzago lezzago merged commit 3e72775 into opensearch-project:main Aug 18, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 18, 2022
Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>

Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
(cherry picked from commit 3e72775)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 18, 2022
Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>

Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
(cherry picked from commit 3e72775)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 18, 2022
Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>

Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
(cherry picked from commit 3e72775)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 18, 2022
Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>

Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
(cherry picked from commit 3e72775)
lezzago pushed a commit that referenced this pull request Aug 22, 2022
Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>

Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
(cherry picked from commit 3e72775)

Co-authored-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
lezzago pushed a commit that referenced this pull request Aug 22, 2022
Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>

Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
(cherry picked from commit 3e72775)

Co-authored-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
lezzago pushed a commit that referenced this pull request Aug 22, 2022
Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>

Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
(cherry picked from commit 3e72775)

Co-authored-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
lezzago pushed a commit that referenced this pull request Aug 22, 2022
Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>

Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
(cherry picked from commit 3e72775)

Co-authored-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants