Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Disable following redirects for webhooks #509

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link

Backport 3e72775 from #507

Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>

Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
(cherry picked from commit 3e72775)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team August 18, 2022 17:50
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2022

Codecov Report

Merging #509 (fb5de54) into 2.x (cb86ddf) will decrease coverage by 9.34%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x     #509      +/-   ##
============================================
- Coverage     70.79%   61.45%   -9.35%     
  Complexity      112      112              
============================================
  Files           124       73      -51     
  Lines          3945     2467    -1478     
  Branches        618      266     -352     
============================================
- Hits           2793     1516    -1277     
+ Misses          971      773     -198     
+ Partials        181      178       -3     
Flag Coverage Δ
dashboards-notifications ?
opensearch-notifications 61.45% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...notifications/core/client/DestinationHttpClient.kt 86.76% <100.00%> (+0.19%) ⬆️
...ns/public/components/ContentPanel/ContentPanel.tsx
...es/Channels/components/modals/DetailsListModal.tsx
...ls/components/modals/DeleteRecipientGroupModal.tsx
...el/components/modals/CreateRecipientGroupModal.tsx
...lic/pages/CreateChannel/components/SNSSettings.tsx
...cations/public/pages/CreateChannel/utils/helper.ts
...blic/pages/CreateChannel/utils/validationHelper.ts
...tions/public/pages/CreateChannel/CreateChannel.tsx
...nnels/components/details/ChannelDetailsActions.tsx
... and 42 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lezzago lezzago merged commit 3b3c1b5 into 2.x Aug 22, 2022
@github-actions github-actions bot deleted the backport/backport-507-to-2.x branch August 22, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants