convert empty httpEntity to {} to avoid DeliveryStatus initialization exception #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exception Signed-off-by: Hailong Cui <ihailong@amazon.com>
xluo-aws
previously approved these changes
Mar 30, 2023
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #648 +/- ##
============================================
+ Coverage 61.70% 61.84% +0.13%
- Complexity 112 114 +2
============================================
Files 73 73
Lines 2494 2495 +1
Branches 265 266 +1
============================================
+ Hits 1539 1543 +4
+ Misses 778 775 -3
Partials 177 177
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
xluo-aws
approved these changes
Apr 4, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 4, 2023
… exception (#648) * convert empty httpEntity to {} to avoid DeliveryStatus initialization exception Signed-off-by: Hailong Cui <ihailong@amazon.com> * add integTest case for webhook empty response Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit 94c225d)
Hailong-am
added a commit
that referenced
this pull request
Apr 4, 2023
… initialization exception (#651) * convert empty httpEntity to {} to avoid DeliveryStatus initialization exception (#648) * convert empty httpEntity to {} to avoid DeliveryStatus initialization exception Signed-off-by: Hailong Cui <ihailong@amazon.com> * add integTest case for webhook empty response Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit 94c225d) * update github actions Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix test build failure Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Hailong Cui <ihailong@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
… exception (#648) * convert empty httpEntity to {} to avoid DeliveryStatus initialization exception Signed-off-by: Hailong Cui <ihailong@amazon.com> * add integTest case for webhook empty response Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit 94c225d)
|
@AWSHurneyt would you mind build and publish common-utils 2.5.1-snapshot to maven? The build depends on it. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
… exception (#648) * convert empty httpEntity to {} to avoid DeliveryStatus initialization exception Signed-off-by: Hailong Cui <ihailong@amazon.com> * add integTest case for webhook empty response Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit 94c225d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
added a commit
that referenced
this pull request
Jul 28, 2023
… initialization exception (#730) * convert empty httpEntity to {} to avoid DeliveryStatus initialization exception (#648) * convert empty httpEntity to {} to avoid DeliveryStatus initialization exception Signed-off-by: Hailong Cui <ihailong@amazon.com> * add integTest case for webhook empty response Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit 94c225d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add missing import Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
added a commit
that referenced
this pull request
Jul 28, 2023
… initialization exception (#660) * convert empty httpEntity to {} to avoid DeliveryStatus initialization exception (#648) * convert empty httpEntity to {} to avoid DeliveryStatus initialization exception Signed-off-by: Hailong Cui <ihailong@amazon.com> * add integTest case for webhook empty response Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit 94c225d) * Add missing import Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Hailong Cui <ihailong@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
convert empty HTTPEntity to a not empty string
{}to fix DeliveryStatus initialization exceptionIssues Resolved
#611
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.