Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run publish maven snapshots on all branches matching pattern #698

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

Hailong-am
Copy link
Collaborator

Description

Run publish maven snapshots on all branches matching pattern
To align with https://github.com/opensearch-project/OpenSearch/blob/main/.github/workflows/publish-maven-snapshots.yml#L6-L9

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Hailong Cui <ihailong@amazon.com>
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #698 (756d067) into main (f730841) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #698   +/-   ##
=========================================
  Coverage     61.84%   61.84%           
  Complexity      114      114           
=========================================
  Files            73       73           
  Lines          2495     2495           
  Branches        266      266           
=========================================
  Hits           1543     1543           
  Misses          775      775           
  Partials        177      177           
Flag Coverage Δ
opensearch-notifications 61.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@gaobinlong gaobinlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@zhichao-aws
Copy link
Member

. is a wildcard in regex, is it same in this case?

@Hailong-am
Copy link
Collaborator Author

Hailong-am commented Jul 3, 2023

. is a wildcard in regex, is it same in this case?

@zhichao-aws It is not wildcard in github workflow syntax, it is a literal character. See Filter Patterns

Copy link
Member

@zhichao-aws zhichao-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Hailong-am Hailong-am merged commit 3a25e53 into opensearch-project:main Jul 3, 2023
13 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 3, 2023
Signed-off-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit 3a25e53)
gaobinlong pushed a commit that referenced this pull request Jul 11, 2023
…700)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit 3a25e53)

Co-authored-by: Hailong Cui <ihailong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants