Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Removed default admin credentials. (#837) #838

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

AWSHurneyt
Copy link
Contributor

(cherry picked from commit 7f38be1)

Description

Manual backport of PR #837

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

(cherry picked from commit 7f38be1)
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c318811) 66.45% compared to head (887791f) 66.45%.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x     #838   +/-   ##
=========================================
  Coverage     66.45%   66.45%           
  Complexity      263      263           
=========================================
  Files            39       39           
  Lines          1717     1717           
  Branches        165      165           
=========================================
  Hits           1141     1141           
  Misses          453      453           
  Partials        123      123           
Flag Coverage Δ
opensearch-notifications 66.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AWSHurneyt AWSHurneyt marked this pull request as ready for review January 24, 2024 18:35
@AWSHurneyt
Copy link
Contributor Author

@zhongnansu
Here's the manual backport. Please review when you have a moment. Thank you!

@amsiglan amsiglan merged commit b0196d4 into opensearch-project:2.x Jan 31, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants