Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: [Feature]: Histogram Support in Event Analytics with Config Options #743

Closed

Conversation

ruchika-narang
Copy link
Contributor

Description

  1. Added support for Histogram
  2. Added config option for legend
  3. Added config option for chart styles
  4. Added color theme

Issues Resolved

#643

Check List

  • New functionality includes basic histogram chart, config options, snapshot test cases and cypress test cases.
    • All tests pass, including unit test, integration test and doctest
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #743 (6617167) into main (c136532) will increase coverage by 5.61%.
The diff coverage is 59.37%.

@@             Coverage Diff              @@
##               main     #743      +/-   ##
============================================
+ Coverage     52.24%   57.85%   +5.61%     
- Complexity        0      291     +291     
============================================
  Files           213      256      +43     
  Lines          6054     8391    +2337     
  Branches       1567     1821     +254     
============================================
+ Hits           3163     4855    +1692     
- Misses         2856     3360     +504     
- Partials         35      176     +141     
Flag Coverage Δ
dashboards-observability 52.53% <59.37%> (+0.28%) ⬆️
opensearch-observability 71.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...fig_panes/config_controls/config_chart_options.tsx 1.96% <0.00%> (-0.13%) ⬇️
...onfig_panes/config_controls/config_input_field.tsx 33.33% <33.33%> (ø)
...onfig_panes/config_controls/config_color_theme.tsx 46.42% <42.30%> (+1.60%) ⬆️
...nfig_panes/config_controls/config_style_slider.tsx 66.66% <50.00%> (ø)
...ents/visualizations/charts/histogram/histogram.tsx 80.55% <82.14%> (+74.30%) ⬆️
...ashboards-observability/common/constants/shared.ts 100.00% <100.00%> (ø)
.../visualizations/charts/histogram/histogram_type.ts 100.00% <100.00%> (ø)
...pensearch/observability/security/SecurityAccess.kt 0.00% <0.00%> (ø)
...opensearch/observability/model/OperationalPanel.kt 87.09% <0.00%> (ø)
...in/org/opensearch/observability/model/Timestamp.kt 93.02% <0.00%> (ø)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c136532...6617167. Read the comment docs.

@ps48
Copy link
Member

ps48 commented May 25, 2022

@ruchika-narang Is this PR still a work in progress? If not can you please remove the WIP tag from the title.

@ruchika-narang
Copy link
Contributor Author

@ps48 Yes, this PR is still a work in progress as I am waiting on the confirmation from @mengweieric for the implementation of color theme.

kavithacm
kavithacm previously approved these changes Jun 16, 2022
ruchika-narang and others added 14 commits June 27, 2022 13:45
Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>
Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>
Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>
Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>
Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>
Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>
Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
@ruchika-narang
Copy link
Contributor Author

Closing this PR as histogram will be completely implemented in sprint2. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants