Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Provide variation of the workload(s) with unsigned_long data type #85

Closed
reta opened this issue Jun 28, 2023 · 7 comments · Fixed by #86
Closed

[FEATURE] Provide variation of the workload(s) with unsigned_long data type #85

reta opened this issue Jun 28, 2023 · 7 comments · Fixed by #86
Assignees
Labels
enhancement New feature or request

Comments

@reta
Copy link
Contributor

reta commented Jun 28, 2023

Is your feature request related to a problem?

We've introduced unsigned_long data type support recently to OpenSearch (see please opensearch-project/OpenSearch#2083), but we don't have workloads for benchmarking it yet (those have been run manually by doing ad-hoc index mapping modifications).

What solution would you like?

Provide variation of the workload(s) with unsigned_long data type

What alternatives have you considered?

Continue with ad-hoc index mapping modifications

Do you have any additional context?

See please opensearch-project/OpenSearch#2083, opensearch-project/OpenSearch#8167

@gashutos
Copy link
Contributor

@bbarani @gkamat , To add something for unsigned_long it will take some time since none of the workload has this data type right now.
But if we can add total_amount sort/range queries in nyc_taxy, that is scaled_float and could be quick to close.

@reta
Copy link
Contributor Author

reta commented Jun 30, 2023

But if we can add total_amount sort/range queries in nyc_taxy, that is scaled_float and could be quick to close.

I was thinking in the same vein, but for a trip_distance, thank you @gashutos

@gashutos
Copy link
Contributor

But if we can add total_amount sort/range queries in nyc_taxy, that is scaled_float and could be quick to close.

I was thinking in the same vein, but for a trip_distance, thank you @gashutos

Yea ! That works too...

@jordarlu
Copy link

Hi, @IanHoang @rishabh6788 , please have a look and if any comments ... thank you!

@IanHoang
Copy link
Collaborator

Apologies for the delay. @gashutos feel free to open a PR to add support for this feature in the nyc_taxis workload. Please ensure that this change is done in a separate test_procedure file, similar to how searchable_snapshot test procedure has its own file in the nyc_taxis/test_procedures/ directory

@reta
Copy link
Contributor Author

reta commented Jul 11, 2023

@gashutos I will take care of it, thank you for the hints folks

@gashutos
Copy link
Contributor

gashutos commented Aug 9, 2023

thanks @reta .
We need for int type as well.
#94
Raised PR for that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
6 participants