Provide variation of the workload(s) with unsigned_long data type #86

reta · 2023-07-12T19:33:34Z

Description

Provide variation of the workload(s) with unsigned_long data type

Issues Resolved

Closes #85

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

reta · 2023-07-12T19:36:08Z

nyc_taxis/index.json

@@ -80,10 +80,10 @@
        "scaling_factor": 100,
        "type": "scaled_float"
      },
-      "trip_distance": {
+      "trip_distance": {%- if trip_distance_type is defined %} {{ trip_distance_type | tojson }} {%- else %} {


@IanHoang would appreciate your feedback on this solution: it turned out we don't need change in test procedure - the default one works just fine (it has aggregations over trip_distrance) but what we need it the mapping type change for trip_distance. Using workload params seems like one of the ways to achieve that (without copy/pasting the whole index).

workload-params.json:

{ "trip_distance_type": { "type": "unsigned_long" } }

And use like that: opensearch-benchmark execute_test --pipeline=benchmark-only --workload=nyc_taxis --target-hosts=localhost:9200 --workload-params=workload-params.json

Yes, you can use workload-params to achieve this, but it would be helpful to update the README with an example, after you decide what to name the trip_distance_type literal.

gkamat · 2023-07-18T19:12:55Z

nyc_taxis/README.md

@@ -73,6 +73,7 @@ This workload allows to overwrite the following parameters using `--workload-par
 * `error_level` (default: "non-fatal"): Available for bulk operations only to specify ignore-response-error-level.
 * `target_throughput` (default: default values for each operation): Number of requests per second, `none` for no limit.
 * `search_clients`: Number of clients that issues search requests.
+* `trip_distance_type` (default: { "scaling_factor": 100, "type": "scaled_float" }): The `trip_distance` field type mapping


This does not seem right. The literal trip_distance_type refers not just to a type, but also includes the scaling factor, so it should probably be renamed.

trip_distance_type

Sure, like trip_distance_field_mapping or trip_distance_mapping?

The former seems more appropriate.

So trip_distance_mapping it is, any more comments? thank you!

gkamat · 2023-07-18T19:15:11Z

nyc_taxis/index.json

@@ -80,10 +80,10 @@
        "scaling_factor": 100,
        "type": "scaled_float"
      },
-      "trip_distance": {
+      "trip_distance": {%- if trip_distance_type is defined %} {{ trip_distance_type | tojson }} {%- else %} {


Yes, you can use workload-params to achieve this, but it would be helpful to update the README with an example, after you decide what to name the trip_distance_type literal.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

gkamat · 2023-07-26T22:59:25Z

nyc_taxis/README.md

+}
+ ```
+
+Save it as `params.json` and provide it to Benchmark with `--workload-params="/path/to/params.json"`.


Please change to "OpenSearch Benchmark". There are some references to "Benchmark" for historical reasons, but they will be updated in due course.

gkamat · 2023-07-26T23:29:45Z

nyc_taxis/README.md

+### Example of specifying parameters using `--workload-params`:
+
+Example:
+```json
+{
+  "trip_distance_mapping": { 
+    "type": "unsigned_long" 
+  } 
+}
+ ```


Can you rename the section title to something like "Specifying Workload Parameters" and add a link to it from the previous section:

This workload allows [specifying the following parameters](#specifying-workload-parameters) using the `-workload-parameters` option to OSB.

You should also indicate that if it is a simple entry, something like --workload-params=search_clients:2 will suffice.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

reta · 2023-08-02T14:36:53Z

@gkamat anything else is holding us off? thank you

gkamat

Thank you for incorporating the suggestions.

gashutos · 2023-08-09T13:48:17Z

@reta @gkamat can we merge this ?

reta · 2023-08-09T15:54:19Z

@reta @gkamat can we merge this ?

I cannot :)

…ensearch-project#86) * Provide variation of the workload(s) with unsigned_long data type Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

…ensearch-project#86) * Provide variation of the workload(s) with unsigned_long data type Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Govind Kamat <govkamat@amazon.com>

* Provide variation of the workload(s) with unsigned_long data type Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Govind Kamat <govkamat@amazon.com>

…ensearch-project#86) * Provide variation of the workload(s) with unsigned_long data type Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Govind Kamat <govkamat@amazon.com>

* Provide variation of the workload(s) with unsigned_long data type Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Govind Kamat <govkamat@amazon.com>

…ensearch-project#86) * Provide variation of the workload(s) with unsigned_long data type Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

…ensearch-project#86) * Provide variation of the workload(s) with unsigned_long data type Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Govind Kamat <govkamat@amazon.com>

* Provide variation of the workload(s) with unsigned_long data type Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Govind Kamat <govkamat@amazon.com>

Provide variation of the workload(s) with unsigned_long data type

87eb41d

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

reta requested review from IanHoang and gkamat as code owners July 12, 2023 19:33

reta commented Jul 12, 2023

View reviewed changes

gkamat requested changes Jul 18, 2023

View reviewed changes

Address review comments

39d8a29

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

reta requested a review from gkamat July 24, 2023 20:14

CaptainDredge mentioned this pull request Jul 26, 2023

[FEATURE] Allow variations of the workload(s) with compatible data types #91

Open

gkamat requested changes Jul 26, 2023

View reviewed changes

reta force-pushed the issue-85 branch 2 times, most recently from 1816fff to e0cb121 Compare July 27, 2023 12:36

Address code review comments

f9b5703

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

reta force-pushed the issue-85 branch from e0cb121 to f9b5703 Compare July 27, 2023 12:36

reta requested a review from gkamat July 27, 2023 12:36

gkamat approved these changes Aug 7, 2023

View reviewed changes

IanHoang merged commit 4499d69 into opensearch-project:main Aug 9, 2023
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide variation of the workload(s) with unsigned_long data type #86

Provide variation of the workload(s) with unsigned_long data type #86

reta commented Jul 12, 2023

reta Jul 12, 2023

reta Jul 12, 2023

gkamat Jul 18, 2023

gkamat Jul 18, 2023

reta Jul 23, 2023

gkamat Jul 26, 2023

reta Jul 26, 2023

gkamat Jul 18, 2023

gkamat Jul 26, 2023

gkamat Jul 26, 2023

reta commented Aug 2, 2023

gkamat left a comment

gashutos commented Aug 9, 2023

reta commented Aug 9, 2023

Provide variation of the workload(s) with unsigned_long data type #86

Provide variation of the workload(s) with unsigned_long data type #86

Conversation

reta commented Jul 12, 2023

Description

Issues Resolved

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

reta commented Aug 2, 2023

gkamat left a comment

Choose a reason for hiding this comment

gashutos commented Aug 9, 2023

reta commented Aug 9, 2023