-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove JCenter Dependencies #1456
Comments
jcenter bintray is down, https://isdown.app/integrations/bintray Do note that jcenter bintray has been sunset, even though it will remain online, we need a campaign to remove our dependency on it. |
Been looking at this a bit - From a
Most of these are coming from DistributionDownloader, but I don't see JCenter defined there. I think this is being brought in by gradle. From https://blog.gradle.org/jcenter-shutdown -
We are using this here: https://github.com/opensearch-project/OpenSearch/blob/main/buildSrc/build.gradle#L98 |
Just noticed that 1.x branch is still explicitly referencing jcenter() here |
Thanks for looking into it @mch2, let's fix OpenSearch on all branches, then I'll cascade this issue into plugins as needed to get rid of anything jcenter. |
So I initiated that backport to 1.x to remove the explicit jcenter() dep in 1.x, but its still blowing up. I think the isue is in gradlePluginPortal(). Unfortunately without gradlePluginPortal() defined we are unable to resolve a few dependencies: Could not determine the dependencies of task ':buildSrc:compileGroovy'.
|
Apparently spotless also uses jcenter and it's on |
Tried an explicit dependency on plugins.gradle.org/m2/ instead of gradlePluginPortal() - looks like the version of spotless we are using is not there so it mirrors to jCenter.
|
@mch2 , Did you try to disable the Gradle module files as noted here? opensearch-project/OpenSearch#1892 (comment) I see that it is trying to load a .module file. |
Thanks @dlvenable for the suggestion. I've tried it but still getting the same trace. With debug enabled I can see plugins.gradle.com redirecting to bintray. Spotless 5.6.1 declares other spotless dependencies that are sourced from bintray, so it redirects there - ex.
|
Updates from gradle - https://status.gradle.com/?_ga=2.113826690.463275434.1641929099-1662752518.1641929099 |
@mch2 , The spotless plugin is also available in Maven Central: It seems something is still preferring the load from the Gradle Plugin Repository rather than Maven Central. I'm currently trying to move Data Prepper plugins to use the classic syntax of |
@dlvenable yep been trying to figure out how to point there instead of jcenter. I think this can be done by declaring a repositories block inside of settings.gradle
Testing it out - so far so good |
Yep this worked for me
|
@mch2 Can I please get some help here - can you edit the issue above with clear instructions of what a project/component/plugin needs to do to fix a similar error? thx |
will do - testing locally with job-scheduler and will update. |
More accurate report link tho their website is having issues: https://status.bintray.com/incidents/d0yvk95zh58j |
To mitigate this:
|
Thanks @mch2 I've added the fix to the top of this issue |
I labeled this 1.2.4 because we can't produce builds without fixing it. |
Does this mean all fixes on plugin level as well even if build doesn't fail should be backported to 1.2 for 1.2.4 release. |
@amitgalitz Yes, these changes need to be backported to all branches that we expect to build. This event aside, JCenter will eventually be permanently offline, and we might as well get ahead of it. If there are BWC tests that pull code and rebuild old versions those branches will need backports as well otherwise those tests will be unable to execute. This might be a good opportunity to check on your BWC tests runs and confirm they are healthy. |
There are still open subtasks, tracking this down |
Lots of remaining hits in https://github.com/search?q=org%3Aopensearch-project+jcenter&type=code |
We've got 22 instances from this query I'll try to drive these all down / create new issues. |
Down to 10 instances of jcenter, here is an updated query. |
Down to 5 instances of jcenter |
There are only 2 outstanding references, both in the alerting plugin |
RE: opensearch-project/notifications#373 - Notification team is not taking changes at this time. |
See the OpenSearch Forum Announcement
Reproduce with
./build.sh manifests/1.2.4/opensearch-1.2.4.yml --component OpenSearch --snapshot
Full Error stack
What’s the problem?
JCenter, which is a repository used in our builds, ceased operations today. Gradle was pulling dependencies from JCenter, and some repos have a direct dependency on it. This broke that the build process for OpenSearch engine, all branches so that the last successful build of 1.3 was at 7:03 AM PT Jan 12th.
To Fix:
Remove JCenter Tasks
The text was updated successfully, but these errors were encountered: