Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support additional qualifiers in OpenSearch and OpenSearch Dashboards #1632

Closed
22 of 24 tasks
Tracked by #1624
bbarani opened this issue Feb 16, 2022 · 9 comments
Closed
22 of 24 tasks
Tracked by #1624

Support additional qualifiers in OpenSearch and OpenSearch Dashboards #1632

bbarani opened this issue Feb 16, 2022 · 9 comments
Assignees
@dblock @peterzhuamazon
Labels
campaign Parent issues of OpenSearch release campaigns. enhancement New Enhancement v2.0.0

Comments

@bbarani
Copy link
Member

bbarani commented Feb 16, 2022 •
edited by dblock

Is your feature request related to a problem? Please describe

Currently the distribution build process doesn't support passing any additional qualifier other than the 3 digit versions hence we have to manually make changes to generate builds with additional qualifiers

Describe the solution you'd like

Add the ability to pass additional qualifier to automated distribution build process. Distribution build process should pick it from the manifest file used for creating the builds. Possible qualifiers includes but not limited to,

  • Beta
  • Alpha
  • RC
  • Preview
  • Preview-1
  • Preview.1

Alpha1

The user should be able to build OpenSearch and Dashboards using the above qualifiers via build process

RC1
@bbarani bbarani added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Feb 16, 2022
@bbarani bbarani changed the title Add ability to pass qualifier to OpenSearch and OpenSearch Dashboards build process Add ability to include additional qualifiers in OpenSearch and OpenSearch Dashboards build process Feb 16, 2022
@bbarani bbarani changed the title Add ability to include additional qualifiers in OpenSearch and OpenSearch Dashboards build process Support qualifiers in OpenSearch and OpenSearch Dashboards build process Feb 16, 2022
@bbarani bbarani added the v2.0.0 label Feb 16, 2022
@peterzhuamazon
Copy link
Member

This needs a change in the current workflows as we do not support qualifiers yet, only raw version numbers in digits.

cc: @dblock

@bbarani bbarani changed the title Support qualifiers in OpenSearch and OpenSearch Dashboards build process Support additional qualifiers in OpenSearch and OpenSearch Dashboards build process Feb 16, 2022
@dblock
Copy link
Member

dblock commented Feb 17, 2022 •
edited

I think we should support the version in the manifest, i.e. I would like to be able to write the following in https://github.com/opensearch-project/opensearch-build/blob/main/manifests/2.0.0/opensearch-2.0.0.yml#L9

version: 2.0-preview # or really anything that's standard Java package version format

The version is already passed around as -Dopensearch.version, and version checks, and checks that ensure all versions match, need to understand this.

@zelinh zelinh removed the untriaged Issues that have not yet been triaged label Feb 17, 2022
@zelinh
Copy link
Member

zelinh commented Feb 17, 2022 •
edited by bbarani

[Triage] We have enough information but we need to groom this issue to understand the scope and effort.

@dblock dblock self-assigned this Mar 8, 2022
This was referenced Mar 9, 2022
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 22, 2022
Merged
Merged
Merged
@joshuali925
Copy link
Member

any instructions on how this should be supported by dashboards plugins?

@dblock
Copy link
Member

dblock commented Mar 23, 2022

any instructions on how this should be supported by dashboards plugins?

I believe @kavilla is looking into it.

@Zhangxunmt Zhangxunmt mentioned this issue Mar 23, 2022
Merged
5 tasks
@aksingh-es aksingh-es mentioned this issue Mar 25, 2022
Merged
1 task
kavilla added a commit to kavilla/opensearch-build that referenced this issue Mar 27, 2022
@kavilla
[BUILD][OSD] Support version qualifier
b9b58ae 
Support version qualifier builds for OpenSearch Dashboards and
OpenSearch Dashboards Plugins.

This will create a zip for plugins with the OpenSearch Dashboards
version + qualifier. But the version of the plugin will remain the
same whilst opensearchDashboardsVersion in the opensearch_dashboards.json
will be the OpenSearch Dashboards version, eg, 1.3.0-alpha1. This is why
the version check needed to be modified a little to ensure that it can
get the version + qualifier and the default version of the plugin.

Updated for plugins as well.

Was able to successfully build and connect OSD 1.3.0-alpha1 to
the release version of OS 1.3.0.

Issue resolved:
opensearch-project/OpenSearch-Dashboards#1340

Issue partially resolved:
opensearch-project#1632

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla mentioned this issue Mar 27, 2022
Merged
1 task
This was referenced Mar 28, 2022
Merged
Merged
Merged
Merged
Closed
kavilla added a commit to kavilla/opensearch-build that referenced this issue Mar 29, 2022
@kavilla
[BUILD][OSD] Support version qualifier
e19ce52 
Support version qualifier builds for OpenSearch Dashboards and
OpenSearch Dashboards Plugins.

This will create a zip for plugins with the OpenSearch Dashboards
version + qualifier. But the version of the plugin will remain the
same whilst opensearchDashboardsVersion in the opensearch_dashboards.json
will be the OpenSearch Dashboards version, eg, 1.3.0-alpha1. This is why
the version check needed to be modified a little to ensure that it can
get the version + qualifier and the default version of the plugin.

Updated for plugins as well.

Was able to successfully build and connect OSD 1.3.0-alpha1 to
the release version of OS 1.3.0.

Issue resolved:
opensearch-project/OpenSearch-Dashboards#1340

Issue partially resolved:
opensearch-project#1632

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@peterzhuamazon peterzhuamazon mentioned this issue Mar 29, 2022
Merged
1 task
kavilla added a commit to kavilla/opensearch-build that referenced this issue Mar 29, 2022
@kavilla
[BUILD][OSD] Support version qualifier
c01c65d 
Support version qualifier builds for OpenSearch Dashboards and
OpenSearch Dashboards Plugins.

This will create a zip for plugins with the OpenSearch Dashboards
version + qualifier. But the version of the plugin will remain the
same whilst opensearchDashboardsVersion in the opensearch_dashboards.json
will be the OpenSearch Dashboards version, eg, 1.3.0-alpha1. This is why
the version check needed to be modified a little to ensure that it can
get the version + qualifier and the default version of the plugin.

Updated for plugins as well.

Was able to successfully build and connect OSD 1.3.0-alpha1 to
the release version of OS 1.3.0.

Issue resolved:
opensearch-project/OpenSearch-Dashboards#1340

Issue partially resolved:
opensearch-project#1632

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@peterzhuamazon
Copy link
Member

Reopen this as @kavilla mistakenly close the meta issue.

@kavilla
Copy link
Member

kavilla commented Mar 29, 2022 •
edited

This is weird, I did not link this issue on the PR besides with the commit but since I mentioned it in the git description github closed it which is new behavior.

Screen Shot 2022-03-29 at 1 39 22 PM

This was referenced Mar 30, 2022
Merged
Closed
@cliu123
Copy link
Member

cliu123 commented Apr 3, 2022

Looks like OpenSearch core doesn't accept plugin version with version_qualifier. Plugin installation failed: https://github.com/opensearch-project/security/runs/5797837160?check_suite_focus=true

2022-04-02T05:49:53.3391925Z -> Installing file:///docker-host/security-plugin.zip
2022-04-02T05:49:53.3426933Z ##[error]Exception in thread "main" java.lang.IllegalArgumentException: the version needs to contain major, minor, and revision, and optionally the build: 2.0.0.0-alpha1
2022-04-02T05:49:53.3428210Z 	at org.opensearch.Version.fromString(Version.java:186)
2022-04-02T05:49:53.3428625Z 	at org.opensearch.plugins.PluginInfo.readFromProperties(PluginInfo.java:222)
2022-04-02T05:49:53.3429203Z 	at org.opensearch.plugins.InstallPluginCommand.loadPluginInfo(InstallPluginCommand.java:811)
2022-04-02T05:49:53.3429760Z 	at org.opensearch.plugins.InstallPluginCommand.installPlugin(InstallPluginCommand.java:870)
2022-04-02T05:49:53.3430273Z 	at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:275)
2022-04-02T05:49:53.3430780Z 	at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:249)
2022-04-02T05:49:53.3431282Z 	at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:100)
2022-04-02T05:49:53.3431744Z 	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
2022-04-02T05:49:53.3432163Z 	at org.opensearch.cli.MultiCommand.execute(MultiCommand.java:104)
2022-04-02T05:49:53.3432587Z 	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
2022-04-02T05:49:53.3432972Z 	at org.opensearch.cli.Command.main(Command.java:101)
2022-04-02T05:49:53.3433771Z 	at org.opensearch.plugins.PluginCli.main(PluginCli.java:60)

@peterzhuamazon peterzhuamazon mentioned this issue Apr 7, 2022
Merged
1 task
@dblock
Copy link
Member

dblock commented Apr 18, 2022

I believe we're done with propagating rc1 qualifiers, closing.

@dblock dblock closed this as completed Apr 18, 2022
@dblock dblock added the campaign Parent issues of OpenSearch release campaigns. label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dblock dblock

@peterzhuamazon peterzhuamazon

Labels
campaign Parent issues of OpenSearch release campaigns. enhancement New Enhancement v2.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@dblock @kavilla @cliu123 @joshuali925 @peterzhuamazon @bbarani @zelinh