Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload test result to upstream job if exists #2028

Closed
wants to merge 2 commits into from

Conversation

tianleh
Copy link
Member

@tianleh tianleh commented Apr 22, 2022

Signed-off-by: Tianle Huang tianleh@amazon.com

Description

Follow up on #2024 (comment)
When non-prod build job triggers the integ test, it will override the result from prod build job if the build number happens to be same. Thus add the logic to upload the test result to its upstream job if it exists. This can avoid such conflict and also allow us to use latest url to access the test result.

Issues Resolved

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2022

Codecov Report

Merging #2028 (0e4dbd5) into main (d08eb7b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2028   +/-   ##
=========================================
  Coverage     94.23%   94.23%           
  Complexity       25       25           
=========================================
  Files           198      198           
  Lines          3902     3902           
  Branches         29       29           
=========================================
  Hits           3677     3677           
  Misses          219      219           
  Partials          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d08eb7b...0e4dbd5. Read the comment docs.

Signed-off-by: Tianle Huang <tianleh@amazon.com>
Signed-off-by: Tianle Huang <tianleh@amazon.com>
@tianleh tianleh changed the title upload test result to upstream job if exits upload test result to upstream job if exists Apr 23, 2022
@tianleh tianleh marked this pull request as ready for review April 23, 2022 08:25
@tianleh tianleh requested a review from a team as a code owner April 23, 2022 08:25
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will revisit this after 2.0.0 release.

@gaiksaya
Copy link
Member

gaiksaya commented Jul 8, 2022

Hi @tianleh , can you resolve the merge conflicts and confirm that this is working as expected?

@tianleh
Copy link
Member Author

tianleh commented Aug 5, 2022

Will revisit when there is bandwidth

@tianleh tianleh closed this Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants