Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rpm build on centos7 and assemble on rockylinux8 to generate digest correctly for FIPS-enabled nodes #2113

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented May 11, 2022

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Make rpm build on centos7 and assemble on rocky8 to generate digest correctly for FIPS-enabled nodes.
This PR also resolve the long standing issue where OSD could not start more than 1 build per version at the same time.

Issues Resolved

#2099

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…orrectly for FIPS-enabled nodes

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon added enhancement New Enhancement cicd jenkins Jenkins related issue labels May 11, 2022
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner May 11, 2022 22:20
@peterzhuamazon peterzhuamazon self-assigned this May 11, 2022
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon changed the title Make rpm build on centos7 and assemble on rocky8 to generate digest correctly for FIPS-enabled nodes Make rpm build on centos7 and assemble on rockylinux8 to generate digest correctly for FIPS-enabled nodes May 12, 2022
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
vars/buildArchive.groovy Outdated Show resolved Hide resolved
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2022

Codecov Report

Merging #2113 (2ce59bc) into main (def4771) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2113      +/-   ##
============================================
- Coverage     94.24%   94.21%   -0.03%     
  Complexity       25       25              
============================================
  Files           203      204       +1     
  Lines          3907     3943      +36     
  Branches         29       29              
============================================
+ Hits           3682     3715      +33     
- Misses          219      222       +3     
  Partials          6        6              
Impacted Files Coverage Δ
...sts/jenkins/jobs/ArchiveAssembleUpload_Jenkinsfile 100.00% <ø> (ø)
tests/jenkins/jobs/BuildArchive_Jenkinsfile 100.00% <ø> (ø)
src/run_sign.py 91.66% <0.00%> (-3.79%) ⬇️
src/manifests/component_manifest.py 92.00% <0.00%> (-3.24%) ⬇️
src/manifests/input_manifest.py 96.55% <0.00%> (-0.68%) ⬇️
src/ci_workflow/ci_args.py 100.00% <0.00%> (ø)
src/test_workflow/test_args.py 100.00% <0.00%> (ø)
src/build_workflow/build_args.py 100.00% <0.00%> (ø)
src/sign_workflow/sign_args.py 100.00% <0.00%> (ø)
src/sign_workflow/sign_artifacts.py 98.07% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update def4771...2ce59bc. Read the comment docs.

@peterzhuamazon peterzhuamazon merged commit 3d6e80b into opensearch-project:main May 13, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-rpm-fips-jenkins branch May 13, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd enhancement New Enhancement jenkins Jenkins related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] RPM add repo_gpgcheck=1 in YUM repo file and enable installation on FIPS mode
4 participants