Organize manifests in folders. #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dblock <dblock@dblock.org>
Codecov Report
@@ Coverage Diff @@
## main #518 +/- ##
==========================================
+ Coverage 70.25% 70.28% +0.03%
==========================================
Files 59 59
Lines 1553 1555 +2
==========================================
+ Hits 1091 1093 +2
Misses 462 462
Continue to review full report at Codecov.
|
Signed-off-by: dblock <dblock@dblock.org>
Signed-off-by: dblock <dblock@dblock.org>
saratvemulapalli
approved these changes
Sep 17, 2021
gaiksaya
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock dblock@dblock.org
Description
After #514 we ended up with a duplicate 1.0.1 manifest because for the early versions we had multiple files and put things in subfolders. In the future we'll have OpenSearch dashboards and possibly some other manifests - let's make folders now. This PR creates 1.1.0, 1.2.0, 2.0.0, etc.
I renamed
BUILD_MANIFESTin the Jenkins job toINPUT_MANIFESTto match the name. After this is merged the Jenkins manual configuration will need to be updated fromBUILD_MANIFEST=opensearch-1.1.0.ymltoINPUT_MANIFEST=1.1.0/opensearch-1.1.0.yml.I deleted
manifest.linux.*.example.ymlas part of #279, we have working examples in the repo from previous versions, and are moving off this system anyway.Added Gradle checks to 1.2.0 and 2.0.0 auto-generated manifests.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.