Build OpenSearch on Windows #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 20, 2021
dblock
force-pushed
the
fix-windows
branch
4 times, most recently
from
b94916e
to
bb69ead
Compare
dblock
force-pushed
the
fix-windows
branch
2 times, most recently
from
6db172d
to
ac23301
Compare
19 tasks
dblock
force-pushed
the
fix-windows
branch
2 times, most recently
from
7aba717
to
c6892f7
Compare
|
Look at this! I'll review tomorrow morning |
Codecov Report
@@ Coverage Diff @@
## main #767 +/- ##
==========================================
- Coverage 91.30% 90.98% -0.33%
==========================================
Files 75 75
Lines 1990 2018 +28
==========================================
+ Hits 1817 1836 +19
- Misses 173 182 +9
Continue to review full report at Codecov.
|
dblock
changed the title
1 task
1 task
gaiksaya
reviewed
Oct 21, 2021
| @@ -48,7 +49,7 @@ def __init__(self): | |||
| self.snapshot = args.snapshot | |||
| self.component = args.component | |||
| self.keep = args.keep | |||
| self.script_path = sys.argv[0].replace("/src/run_build.py", "/build.sh") | |||
| self.script_path = sys.argv[0].replace(os.path.sep + os.path.join("src", "run_build.py"), f"{os.path.sep}build.sh") | |||
gaiksaya
approved these changes
Oct 21, 2021
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@dblock.org>
Signed-off-by: dblock <dblock@dblock.org>
Signed-off-by: dblock <dblock@dblock.org>
peternied
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes tests on Windows:
os.path.joinvs. concatenating string paths or paths with a/separator.tests/tests_build_workflow.Issues Resolved
On top of #772.
Part of #33.
With this PR and fixes in opensearch-project/OpenSearch#1412 you can successfully build OpenSearch 2.0.0 min with the following manifest.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.