Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: retry command substitution on Windows. #804

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Oct 26, 2021

Signed-off-by: dblock dblock@dblock.org

Description

Before:

2021-10-25 23:27:37 ERROR    Error building common-utils, retry with: ./src/run_build.py manifests/1.1.0/opensearch-1.1.0.yml --component common-utils --snapshot

After:

2021-10-26 00:23:48 ERROR    Error building common-utils, retry with: ./build.sh manifests/1.1.0/opensearch-1.1.0.yml --component common-utils --snapshot

On Windows, because we always run under bash the paths in these messages are unix, not Windows.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@dblock.org>
@dblock dblock changed the title Fix: retry command substitution. Fix: retry command substitution on Windows. Oct 26, 2021
@dblock dblock merged commit d7ae0bf into opensearch-project:main Oct 26, 2021
@dblock dblock deleted the sh-retry branch October 26, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants