Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce TCP Protocol for target groups #115

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

gaiksaya
Copy link
Member

Description

Enforce TCP Protocol for target groups. By default, inherits the protocol of the listener in this case TLS when port is 443 and certificateArn is provided.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.55%. Comparing base (2a3968b) to head (df9319e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   82.55%   82.55%           
=======================================
  Files           6        6           
  Lines         470      470           
  Branches      179      179           
=======================================
  Hits          388      388           
  Misses         82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterzhuamazon
Copy link
Member

Only one question, if you dont enforce TCP will it ever go to UDP or something else?

@gaiksaya
Copy link
Member Author

Only one question, if you dont enforce TCP will it ever go to UDP or something else?

No this is what they say

    /**
     * Protocol for target group, expects TCP, TLS, UDP, or TCP_UDP.
     *
     * @default - inherits the protocol of the listener
     */

So it all depends on listener. And for listener default it TCP:

    /**
     * Protocol for listener, expects TCP, TLS, UDP, or TCP_UDP.
     *
     * @default - TLS if certificates are provided. TCP otherwise.
     */

@gaiksaya gaiksaya merged commit 9ce1869 into opensearch-project:main Mar 15, 2024
5 checks passed
@gaiksaya gaiksaya deleted the fix-protocol branch March 15, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants