Add option to create internal NLB #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishabh Singh <sngri@amazon.com>
rishabh6788
requested review from
peterzhuamazon,
bbarani,
gaiksaya,
zelinh,
jordarlu,
prudhvigodithi and
Divyaasm
as code owners
| @@ -151,6 +151,9 @@ export class OsClusterEntrypoint { | |||
| const use50heap = `${scope.node.tryGetContext('use50PercentHeap')}`; | |||
| const use50PercentHeap = use50heap === 'true'; | |||
There was a problem hiding this comment.
Thanks @rishabh6788 , where are we using this use50PercentHeap value?
There was a problem hiding this comment.
This is optional parameter, processed here. @prudhvigodithi
There was a problem hiding this comment.
it was included due to formatting fix.
prudhvigodithi
approved these changes
May 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
Signed-off-by: Rishabh Singh <sngri@amazon.com> (cherry picked from commit b450ca4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds option to create internal NLB.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.