Add ec2 instance options for data and ml nodes #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabh6788
requested review from
peterzhuamazon,
bbarani,
gaiksaya,
zelinh,
jordarlu,
prudhvigodithi and
Divyaasm
as code owners
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
=======================================
Coverage ? 81.12%
=======================================
Files ? 5
Lines ? 339
Branches ? 102
=======================================
Hits ? 275
Misses ? 64
Partials ? 0 |
This was referenced May 18, 2023
rishabh6788
force-pushed
the
main
branch
2 times, most recently
from
95319a3
to
9167c9f
Compare
|
@gaiksaya @peterzhuamazon @prudhvigodithi Need your review. |
gaiksaya
reviewed
May 24, 2023
README.md
Outdated
| @@ -51,6 +51,8 @@ In order to deploy both the stacks the user needs to provide a set of required a | |||
| | clientNodeCount (Optional) | integer | Number of dedicated client nodes, default is 0 | | |||
| | ingestNodeCount (Optional) | integer | Number of dedicated ingest nodes, default is 0 | | |||
| | mlNodeCount (Optional) | integer | Number of dedicated machine learning nodes, default is 0 | | |||
| | dataInstanceType (Optional) | string | Ec2 instance type for data node, defaults to r5.large. See options in `lib/opensearch-config/node-config.ts` for available options. E.g., `-c dataInstanceType=m5.xlarge` | | |||
There was a problem hiding this comment.
Suggested change
| | dataInstanceType (Optional) | string | Ec2 instance type for data node, defaults to r5.large. See options in `lib/opensearch-config/node-config.ts` for available options. E.g., `-c dataInstanceType=m5.xlarge` | | |
| | dataInstanceType (Optional) | string | EC2 instance type for data node, defaults to r5.large. See options in `lib/opensearch-config/node-config.ts` for available options. E.g., `-c dataInstanceType=m5.xlarge` | |
README.md
Outdated
| @@ -51,6 +51,8 @@ In order to deploy both the stacks the user needs to provide a set of required a | |||
| | clientNodeCount (Optional) | integer | Number of dedicated client nodes, default is 0 | | |||
| | ingestNodeCount (Optional) | integer | Number of dedicated ingest nodes, default is 0 | | |||
| | mlNodeCount (Optional) | integer | Number of dedicated machine learning nodes, default is 0 | | |||
| | dataInstanceType (Optional) | string | Ec2 instance type for data node, defaults to r5.large. See options in `lib/opensearch-config/node-config.ts` for available options. E.g., `-c dataInstanceType=m5.xlarge` | | |||
| | mlInstanceType (Optional) | string | Ec2 instance type for ml node, defaults to r5.large. See options in `lib/opensearch-config/node-config.ts` for available options. E.g., `-c mlInstanceType=m5.xlarge` | | |||
There was a problem hiding this comment.
Suggested change
| | mlInstanceType (Optional) | string | Ec2 instance type for ml node, defaults to r5.large. See options in `lib/opensearch-config/node-config.ts` for available options. E.g., `-c mlInstanceType=m5.xlarge` | | |
| | mlInstanceType (Optional) | string | EC2 instance type for ml node, defaults to r5.large. See options in `lib/opensearch-config/node-config.ts` for available options. E.g., `-c mlInstanceType=m5.xlarge` | |
Comment on lines
+58
to
+59
| readonly dataEc2InstanceType: InstanceType, | ||
| readonly mlEc2InstanceType: InstanceType, |
There was a problem hiding this comment.
Should we enable instance type for all types of nodes including leader, etc? Keep defaults but allow option to override for others too?
There was a problem hiding this comment.
Not required as manager and client nodes not really do any heavy lifting and are only involved in book-keeping and traffic routing tasks.
We can take it up in future if the need arises.
@gaiksaya
Signed-off-by: Rishabh Singh <sngri@amazon.com>
gaiksaya
changed the title
gaiksaya
approved these changes
May 24, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
Signed-off-by: Rishabh Singh <sngri@amazon.com> (cherry picked from commit 465f824) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds ec2 isntance options for data and ml nodes.
This PR also adds the ability to set seed node to data instance type and storage when there is no dedicated master node configured.
The single-node is fixed to eg.2xlarge due to urgent requirement for it to be used for benchmarking test. Will update this to use the passed data ec2 instance type post P0 release.
Other nodes except data and ml default to
c5.xlarge, options for them can be provided in subsequent PRs.Issues Resolved
#6 #27 #28
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.