make r5.2xlarge as default instance type #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabh6788
requested review from
peterzhuamazon,
bbarani,
gaiksaya,
zelinh,
jordarlu,
prudhvigodithi and
Divyaasm
as code owners
Signed-off-by: Rishabh Singh <sngri@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
==========================================
- Coverage 81.12% 80.28% -0.84%
==========================================
Files 5 5
Lines 339 345 +6
Branches 102 104 +2
==========================================
+ Hits 275 277 +2
- Misses 64 68 +4
|
Do we have an issue that we can link here? Not sure when you say benchmark run code is it benchmarks config or performance testing framework? |
gaiksaya
approved these changes
May 30, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
Signed-off-by: Rishabh Singh <sngri@amazon.com> (cherry picked from commit 63d3731) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make r5.2xlarge as default instance type.
This default increase it to test benchmark run metrics with our existing performance dashboards that run on r5.2xlarge type instances. Once we add the option to select instance type in our benchmark run code we will downgrade the defaults here.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.