Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make r5.xlarge as default instance type #33

Merged
merged 1 commit into from
May 31, 2023

Conversation

rishabh6788
Copy link
Collaborator

Description

Make r5.xlarge as default instance type.
This default increase it to test benchmark run metrics with our existing performance dashboards that run on r5.2xlarge type instances.
Once we add the option to select instance type in our benchmark run code we will downgrade the defaults here.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rishabh Singh <sngri@amazon.com>
@rishabh6788 rishabh6788 merged commit fce3055 into opensearch-project:main May 31, 2023
3 checks passed
@opensearch-trigger-bot
Copy link

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-33-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fce305519cd84197fcbe2daa60880319aba330ec
# Push it to GitHub
git push --set-upstream origin backport/backport-33-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-33-to-1.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 24, 2023
Signed-off-by: Rishabh Singh <sngri@amazon.com>
(cherry picked from commit fce3055)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants