Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for remote-store feature in OpenSearch #38

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

rishabh6788
Copy link
Collaborator

@rishabh6788 rishabh6788 commented Jun 20, 2023

Description

This PR adds support to enable remote-store feature in OpenSearch. See feature details here

Issues Resolved

opensearch-project/OpenSearch#8087.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #38 (903b36c) into main (7e7d6cf) will increase coverage by 0.66%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   79.76%   80.42%   +0.66%     
==========================================
  Files           5        6       +1     
  Lines         346      373      +27     
  Branches      104      112       +8     
==========================================
+ Hits          276      300      +24     
- Misses         70       73       +3     
Impacted Files Coverage Δ
lib/infra/infra-stack.ts 92.06% <78.94%> (-1.58%) ⬇️
lib/infra/remote-store-resources.ts 100.00% <100.00%> (ø)
lib/os-cluster-entrypoint.ts 85.12% <100.00%> (+0.25%) ⬆️

@rishabh6788
Copy link
Collaborator Author

Currently blocked on opensearch-project/OpenSearch#8158.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rishabh6788 add some comments regarding changes.
Thanks.

lib/infra/infra-stack.ts Show resolved Hide resolved
lib/infra/infra-stack.ts Outdated Show resolved Hide resolved
lib/infra/infra-stack.ts Outdated Show resolved Hide resolved
lib/infra/remote-store-resources.ts Outdated Show resolved Hide resolved
Signed-off-by: Rishabh Singh <sngri@amazon.com>
@rishabh6788 rishabh6788 merged commit d1adf6d into opensearch-project:main Jun 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants