Provide support to configure new instance types like r5.4xl/8xl, r6g.4xl/8xl and i3 instances #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4xl/8xl and i3 instances. Add new configuration parameter to allow passing volumeType like standard,gp2,gp3 to configure ebs volumes on instance types Signed-off-by: Sorabh Hamirwasia <hsorabh@amazon.com>
sohami
requested review from
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi and
Divyaasm
as code owners
sohami
force-pushed
the
new-instance-ebs-volume
branch
from
68a6ced
to
b1ac680
Compare
|
@rishabh6788 @prudhvigodithi Can you please help review it ? |
Codecov Report
@@ Coverage Diff @@
## main #47 +/- ##
==========================================
- Coverage 80.42% 77.69% -2.74%
==========================================
Files 6 6
Lines 373 417 +44
Branches 112 128 +16
==========================================
+ Hits 300 324 +24
- Misses 73 93 +20
|
sohami
force-pushed
the
new-instance-ebs-volume
branch
from
b1ac680
to
8216bb3
Compare
Signed-off-by: Sorabh Hamirwasia <hsorabh@amazon.com>
sohami
force-pushed
the
new-instance-ebs-volume
branch
from
8216bb3
to
b11827e
Compare
|
@sohami Thank you for your contribution. LGTM. |
rishabh6788
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for more instance types and GP3 EBS volume type for cluster setup. New parameter for EBS volume is
--context storageVolumeType=gp3/gp2/standard. Have updated the README with new parameter tooHave tested and verified that gp3 is configured correctly for different instances.
Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.