Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable IMDSv2 on all instances #49

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

gaiksaya
Copy link
Member

Description

Enabling IMDSv2 on all nodes by default in order to have more secure calls. Read more about it https://aws.amazon.com/blogs/security/defense-in-depth-open-firewalls-reverse-proxies-ssrf-vulnerabilities-ec2-instance-metadata-service/

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #49 (95aef43) into main (d532a92) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   78.17%   78.17%           
=======================================
  Files           6        6           
  Lines         417      417           
  Branches      128      128           
=======================================
  Hits          326      326           
  Misses         91       91           
Files Changed Coverage Δ
lib/infra/infra-stack.ts 92.12% <100.00%> (ø)

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will let @rishabh6788 do another round of review.
Add some comments.

Thanks.

lib/infra/infra-stack.ts Show resolved Hide resolved
test/os-cluster.test.ts Show resolved Hide resolved
@gaiksaya gaiksaya merged commit 791d509 into opensearch-project:main Aug 30, 2023
5 checks passed
@gaiksaya gaiksaya deleted the enable-imdsv2 branch August 30, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants