Addresses changes made to security demo config install tool #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabh6788
requested review from
peterzhuamazon,
bbarani,
gaiksaya,
zelinh,
jordarlu,
prudhvigodithi and
Divyaasm
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
+ Coverage 80.08% 80.21% +0.12%
==========================================
Files 7 7
Lines 467 470 +3
Branches 134 136 +2
==========================================
+ Hits 374 377 +3
Misses 93 93 ☔ View full report in Codecov by Sentry. |
gaiksaya
reviewed
Dec 21, 2023
README.md
Outdated
| - [Code of Conduct](#code-of-conduct) | ||
| - [Security](#security) | ||
| - [License](#license) | ||
| - [CDK for deploying single-node and multi-node OpenSearch cluster with OpenSearch Dashboards](#cdk-for-deploying-single-node-and-multi-node-opensearch-cluster-with-opensearch-dashboards) |
There was a problem hiding this comment.
Is this duplicate of line 1? Not required right?
There was a problem hiding this comment.
VS code editor added it for some reason. Removed it.
lib/os-cluster-entrypoint.ts
Outdated
| const insecure = securityDisabled === 'true'; | ||
|
|
||
| const adminPassword: String = insecure ? '' : `${scope.node.tryGetContext('adminPassword')}`; | ||
| console.log(`Admin password is ${adminPassword}`); |
There was a problem hiding this comment.
Debug console statement? Printing password to the console can be risky esp when it comes to deployments.
There was a problem hiding this comment.
Added it for testing, missed to remove it. Removed.
Signed-off-by: Rishabh Singh <sngri@amazon.com>
gaiksaya
approved these changes
Dec 21, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were recent changes to security demo configuration setup which now requires a custom admin Password to be setup. This PR updates the documentation and related code change.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.