Publish all modules to npmjs #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
gaiksaya
requested review from
peterzhuamazon,
bbarani,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi and
Divyaasm
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
=======================================
Coverage 81.87% 81.87%
=======================================
Files 6 6
Lines 447 447
Branches 167 167
=======================================
Hits 366 366
Misses 81 81 ☔ View full report in Codecov by Sentry. |
prudhvigodithi
approved these changes
Jan 23, 2024
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The recent version of opsnearch-cluster-cdk does not publish all modules to npmjs causing the imports in extending package to be missing.
This PR builds all the installable modules and publish the final tarball generated using npm-pack command.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.