[MD] Replace fake data source endpoint with configurable real endpoint #1260

zhongnansu · 2024-05-01T18:20:17Z

Description

Replace fake data source endpoint with real endpoint (auth, and no auth)
skip sigv4 related tests since infra workflow doesn't support create , and those tests will fail

Test

There are 4 CI related to the function tests is OSD core, and they all failed, not caused by MDS tests and test infra.

e2e windows, with security: failed to spin up opensearch, not even reach cypress test step

e2e windows, without security: failed because workflow template doesn't allow passing osd arguments data_source.enabled=true

opensearch-dashboards-functional-test/.github/workflows/cypress-workflow-bundle-snapshot-based-windows.yml

Lines 20 to 21 in 79d98ca

    
           # not useful now as the windows e2e template currently do not allow serving parameters 
        
           #osd-serve-args: --data_source.enabled=true --vis_builder.enabled=true

e2e linux, with security: cypress crashed, not even reach to MDS test
e2e linux, without security: MDS test can pass, viz builder tests are failing

Issues Resolved

#1202

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Zhongnan Su <szhongna@amazon.com>

yujin-emma · 2024-05-03T19:57:43Z

...ch-dashboards/opensearch-dashboards/datasource-management-plugin/1_create_datasource.spec.js

@@ -104,11 +104,11 @@ if (Cypress.env('DATASOURCE_MANAGEMENT_ENABLED')) {
          'app/management/opensearch-dashboards/dataSources'
        );
      });
-
-      it('with sigV4 and all required inputs to connect to OpenSearch Service', () => {
+      // TODO: once create datasource with sigv4 is in plance, remove the skip


I added that on purpose, since current test infra in workflow was added to support no auth and basic auth. It doesn't support creating AOS/AOSS domain yet. We need to think of a way to either creating one from infra, or add a long running one by configuring it in github secrets for testing purpose

can add more env variables too whether to ran specific suite of tests

kavilla · 2024-05-04T07:02:27Z

.github/workflows/cypress-workflow-bundle-snapshot-based.yml

@@ -17,12 +17,12 @@ jobs:
    with:
      test-name: Core Dashboards using Bundle Snapshot
      test-command: env CYPRESS_NO_COMMAND_LOG=1 CYPRESS_ML_COMMONS_DASHBOARDS_ENABLED=true CYPRESS_VISBUILDER_ENABLED=true CYPRESS_DATASOURCE_MANAGEMENT_ENABLED=true yarn cypress:run-with-security --browser chromium --spec 'cypress/integration/core-opensearch-dashboards/opensearch-dashboards/**/*.js'
-      osd-serve-args: --data_source.enabled=true --vis_builder.enabled=true --ml_commons_dashboards.enabled=true
+      osd-serve-args: --data_source.enabled=true --data_source.ssl.verificationMode=none --vis_builder.enabled=true --ml_commons_dashboards.enabled=true 


just a heads up.

the cypress workflow in OSD doesn't run these tests per PR. It runs with the ciGroup scripts.

The workflow then calls them here: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/.github/workflows/cypress_workflow.yml#L122

Then OSD gets started up with:
https://github.com/opensearch-project/OpenSearch-Dashboards/blame/main/.github/workflows/cypress_workflow.yml#L33

Should creating a new start cmd in OSD? that does something like yarn start --data_source.enabled --data_source.ssl.verificationMode=none Then create a new ciGroup(s) for MDS? To start up OSD with MDS and calls the script from this repo to get the MDS tests and run them per PR.

@kavilla Thanks for sharing how cypress workflow in OSD runs tests of functional test repo! I think we can just modify the existing START_CMD to add --data_source.enabled=true, data_source.ssl.verificationMode=none. For ciGroup, I think there's an existing one for MDS

opensearch-dashboards-functional-test/package.json

Line 32 in 79d98ca

"osd:ciGroup5": "echo \"datasource-management-plugin/*.js\"",

SuZhou-Joe · 2024-05-06T01:30:50Z

Seems this PR is tagged as 2.15, is that correct? @zhongnansu

zhongnansu · 2024-05-06T06:19:44Z

Seems this PR is tagged as 2.15, is that correct? @zhongnansu

I think it should be tagged 2.14.0. Same for this PR which adds the infra for MDS, #1146 could you help add 2.14.0 label for both?

Signed-off-by: Zhongnan Su <szhongna@amazon.com> (cherry picked from commit 8b10f8f)

Signed-off-by: Zhongnan Su <szhongna@amazon.com> (cherry picked from commit 8b10f8f) Co-authored-by: Zhongnan Su <szhongna@amazon.com>

Signed-off-by: Zhongnan Su <szhongna@amazon.com> (cherry picked from commit 8b10f8f)

Signed-off-by: Zhongnan Su <szhongna@amazon.com> (cherry picked from commit 8b10f8f) Co-authored-by: Zhongnan Su <szhongna@amazon.com>

zhongnansu force-pushed the test-md-infra branch 3 times, most recently from e3efc7a to 6d23887 Compare May 2, 2024 00:44

[MD] Replace fake endpoint with real endpoint

5a80bcf

Signed-off-by: Zhongnan Su <szhongna@amazon.com>

zhongnansu force-pushed the test-md-infra branch from 6d23887 to 5a80bcf Compare May 3, 2024 05:58

zhongnansu changed the title ~~test MD infra~~ [MD] Replace fake endpoint with real endpoint May 3, 2024

zhongnansu changed the title ~~[MD] Replace fake endpoint with real endpoint~~ [MD] Replace fake data source endpoint with real endpoint May 3, 2024

zhongnansu changed the title ~~[MD] Replace fake data source endpoint with real endpoint~~ [MD] Replace fake data source endpoint with configurable real endpoint May 3, 2024

zhongnansu marked this pull request as ready for review May 3, 2024 18:01

zhongnansu requested review from tianleh, kavilla, ohltyler, CCongWang, ashwin-pc, peterzhuamazon, ananzh, prudhvigodithi, xluo-aws, Hailong-am, SuZhou-Joe, ruanyl, wanglam and raintygao as code owners May 3, 2024 18:01

yujin-emma reviewed May 3, 2024

View reviewed changes

BionIT approved these changes May 3, 2024

View reviewed changes

Hailong-am approved these changes May 4, 2024

View reviewed changes

kavilla reviewed May 4, 2024

View reviewed changes

kavilla approved these changes May 4, 2024

View reviewed changes

kavilla added backport 2.x v2.15.0 labels May 4, 2024

ellazhu1022 approved these changes May 6, 2024

View reviewed changes

CCongWang merged commit 8b10f8f into opensearch-project:main May 6, 2024
39 of 43 checks passed

opensearch-trigger-bot bot pushed a commit that referenced this pull request May 6, 2024

[MD] Replace fake endpoint with real endpoint (#1260)

bfa066e

Signed-off-by: Zhongnan Su <szhongna@amazon.com> (cherry picked from commit 8b10f8f)

opensearch-trigger-bot bot mentioned this pull request May 6, 2024

[Backport 2.x] [MD] Replace fake data source endpoint with configurable real endpoint #1273

Merged

SuZhou-Joe pushed a commit that referenced this pull request May 7, 2024

[MD] Replace fake endpoint with real endpoint (#1260) (#1273)

8b2af05

Signed-off-by: Zhongnan Su <szhongna@amazon.com> (cherry picked from commit 8b10f8f) Co-authored-by: Zhongnan Su <szhongna@amazon.com>

SuZhou-Joe added v2.14.0 backport 2.14 and removed v2.15.0 labels May 7, 2024

opensearch-trigger-bot bot pushed a commit that referenced this pull request May 7, 2024

[MD] Replace fake endpoint with real endpoint (#1260)

f415c35

Signed-off-by: Zhongnan Su <szhongna@amazon.com> (cherry picked from commit 8b10f8f)

opensearch-trigger-bot bot mentioned this pull request May 7, 2024

[Backport 2.14] [MD] Replace fake data source endpoint with configurable real endpoint #1279

Merged

SuZhou-Joe pushed a commit that referenced this pull request May 7, 2024

[MD] Replace fake endpoint with real endpoint (#1260) (#1279)

9262706

Signed-off-by: Zhongnan Su <szhongna@amazon.com> (cherry picked from commit 8b10f8f) Co-authored-by: Zhongnan Su <szhongna@amazon.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MD] Replace fake data source endpoint with configurable real endpoint #1260

[MD] Replace fake data source endpoint with configurable real endpoint #1260

zhongnansu commented May 1, 2024 •

edited

Loading

yujin-emma May 3, 2024

zhongnansu May 3, 2024

kavilla May 4, 2024

kavilla May 4, 2024

zhongnansu May 5, 2024 •

edited

Loading

SuZhou-Joe commented May 6, 2024 •

edited

Loading

zhongnansu commented May 6, 2024

	# not useful now as the windows e2e template currently do not allow serving parameters
	#osd-serve-args: --data_source.enabled=true --vis_builder.enabled=true

[MD] Replace fake data source endpoint with configurable real endpoint #1260

[MD] Replace fake data source endpoint with configurable real endpoint #1260

Conversation

zhongnansu commented May 1, 2024 • edited Loading

Description

Test

Issues Resolved

Check List

yujin-emma May 3, 2024

Choose a reason for hiding this comment

zhongnansu May 3, 2024

Choose a reason for hiding this comment

kavilla May 4, 2024

Choose a reason for hiding this comment

kavilla May 4, 2024

Choose a reason for hiding this comment

zhongnansu May 5, 2024 • edited Loading

Choose a reason for hiding this comment

SuZhou-Joe commented May 6, 2024 • edited Loading

zhongnansu commented May 6, 2024

zhongnansu commented May 1, 2024 •

edited

Loading

zhongnansu May 5, 2024 •

edited

Loading

SuZhou-Joe commented May 6, 2024 •

edited

Loading