Allow URL params for Security plugin intercept calls #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
SuZhou-Joe
approved these changes
May 7, 2024
|
Will help to merge once all the CI checks complete. |
|
Thanks @SuZhou-Joe! |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
…ensearch-dashboards-functional-test into add-wildcard-commands
1 task
SuZhou-Joe
reviewed
May 7, 2024
cypress/integration/plugins/security-dashboards-plugin/change_tenant_successfully.js
Show resolved
Hide resolved
…tenant_successfully.js Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
DarshitChanpura
approved these changes
May 7, 2024
kavilla
approved these changes
May 8, 2024
ashwin-pc
approved these changes
May 8, 2024
Signed-off-by: Craig Perkins <cwperx@amazon.com>
…ensearch-dashboards-functional-test into add-wildcard-commands
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
3 tasks
…link.js Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1276-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ed49fa53ab96265f989576ca0a25b3d3b30948d0
# Push it to GitHub
git push --set-upstream origin backport/backport-1276-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
cwperks
added a commit
to cwperks/opensearch-dashboards-functional-test
that referenced
this pull request
May 16, 2024
…ect#1276) * Allow url params in intercept Signed-off-by: Craig Perkins <cwperx@amazon.com> * Disable home modal Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update cypress/integration/plugins/security-dashboards-plugin/change_tenant_successfully.js Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Fix CI check on main Signed-off-by: Craig Perkins <cwperx@amazon.com> * Change text back Signed-off-by: Craig Perkins <cwperx@amazon.com> * Move tenancy test over Signed-off-by: Derek Ho <dxho@amazon.com> * Use correct header when creating dashboard in tenancy_change_on_shortlink.js Signed-off-by: Craig Perkins <cwperx@amazon.com> * Adjust import Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove @ Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add wildcard Signed-off-by: Craig Perkins <cwperx@amazon.com> * Fix sanity_tests.spec.js Signed-off-by: Craig Perkins <cwperx@amazon.com> * Close the modal Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: Derek Ho <dxho@amazon.com> (cherry picked from commit ed49fa5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes integ test failures seen in the 2.14.0 integ test for the security-dashboards-plugin: opensearch-project/security-dashboards-plugin#1893
In 2.14.0, the security-dashboards-plugin added support for multiple data sources (MDS) and allows dataSourceId to pass as a url param for MDS enabled Dashboards instances. This change updates the calls to
cy.interceptto allow url params. The tests currently hang on these calls.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.