[Dashboard De-Angular] Let dashboard finish loading after adding a new vis #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbyhu2000
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
Closed
26 tasks
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
abbyhu2000
force-pushed
the
dashboard-plugin-fix
branch
from
9a804bc
to
e0cd5a9
Compare
SuZhou-Joe
approved these changes
Jul 5, 2023
kavilla
approved these changes
Jul 6, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> (cherry picked from commit e1fad26)
ananzh
pushed a commit
that referenced
this pull request
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add one line
cy.waitForLoader();in the vis-builder/dashboard test.Previously, after we create a new vis builder from a dashboard, we immediately test if the vis builder exists in that dashboard without letting the dashboard page finish loading.