This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
Add 2PR approval for release #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
gaiksaya
requested review from
VachaShah,
dblock,
harshavamsi and
Yury-Fridlyand
as code owners
gaiksaya
commented
Mar 1, 2023
| with: | ||
| secret: ${{ github.TOKEN }} | ||
| approvers: ${{ steps.get_approvers.outputs.approvers }} | ||
| minimum-approvals: 2 |
There was a problem hiding this comment.
I kept this number as 2 but let me know if it needs to change to some other number.
Yury-Fridlyand
approved these changes
Mar 1, 2023
VachaShah
approved these changes
Mar 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change retrieves the codeowner's list from .github/codeowners file and adds them as approvers for releasing opensearch-dsl-py.
Here is a sample issue that is created when this workflow runs: gaiksaya#6
Once approved, the workflow continues to run as usual.
Note: This approval duration is subject to the broader 72 hours timeout for a workflow.
Issues Resolved
related opensearch-project/opensearch-build#3111
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.