Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing paths for some APIs #134

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

VachaShah
Copy link
Collaborator

Signed-off-by: Vacha Shah vachshah@amazon.com

Description

Fixing url paths for some APIs after type removal.

Issues Resolved

Closes #132

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vacha Shah <vachshah@amazon.com>
@dblock
Copy link
Member

dblock commented Jul 11, 2022

I am new to this codebase and don't quite understand what's going on :) Looks like the PR swaps the order of _DocumentId and, for example, _create? But we just removed types ... Help me understand like a 2yo?

@dblock
Copy link
Member

dblock commented Jul 11, 2022

Thanks. I suppose we don't have integration tests for this? I'd expect some to fail against OpenSearch 2.x. Open an issue at least?

@VachaShah
Copy link
Collaborator Author

Thanks. I suppose we don't have integration tests for this? I'd expect some to fail against OpenSearch 2.x. Open an issue at least?

Yes currently these APIs are not part of the integration test. I have created #135 to add this issue.

@saratvemulapalli saratvemulapalli merged commit abf672c into opensearch-project:main Jul 20, 2022
@VachaShah VachaShah deleted the fix-132 branch July 20, 2022 22:26
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 21, 2022
Signed-off-by: Vacha Shah <vachshah@amazon.com>
(cherry picked from commit abf672c)
VachaShah added a commit that referenced this pull request Jul 21, 2022
Signed-off-by: Vacha Shah <vachshah@amazon.com>
(cherry picked from commit abf672c)

Co-authored-by: Vacha Shah <vachshah@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] UpdateRequest never update.
3 participants